Prevent dispatch_workflow schema probes

[bradygaster]

Closes #1765

Summary

• Add WRITE-ONCE guidance to the implement worker's merge-continuation dispatch_workflow instruction.
• Add a contract assertion that the worker prompt forbids empty/schema-probe dispatch calls and names noop as the alternative.

Context

Live run 32324473906 in bradygaster/aspiregregator-squad-e2e produced two safe-output calls: first an empty dispatch_workflow schema-discovery probe, then the correct { workflow_name: "squad", inputs: { command: "implement", issue_number: "5" } } payload. gh-aw safe-output collection for this item is max: 1, so the first matching item won and the real payload was silently discarded.

This PR is a workaround in our own prompt for a gh-aw collection behavior we do not control. The #1752 safety net worked as intended: it surfaced the missing command as a visible failure instead of letting Squad silently default to cast.

Validation

• npx vitest run test/gh-aw-quality.test.ts
• npx vitest run test/gh-aw-implement-workflow.test.ts

[github-actions]

🟡 Impact Analysis — PR #1766

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	2
Files added	0
Files modified	2
Files deleted	0
Modules touched	2

🎯 Risk Factors

• 2 files changed (≤5 → LOW)
• 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (1 file)

• workflows/squad-implement-worker.md

tests (1 file)

• test/gh-aw-quality.test.ts

---

This report is generated automatically for every PR. See #733 for details.

[github-actions]

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 5ba613b

PR Scope: 🔧 Infrastructure

⚠️ 3 item(s) to address before review

Status	Check	Details
❌	Single commit	2 commits — consider squashing before review
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	No source files changed — changeset not required
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
❌	Copilot threads resolved	1 unresolved Copilot thread(s) — fix and resolve before merging
✅	CI passing	All checks passing

Files Changed (2 files, +27 −5)

File	+/−
test/gh-aw-quality.test.ts	+14 −0
workflows/squad-implement-worker.md	+13 −5

Total: +27 −5

---

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

[Copilot]

Pull request overview

This PR hardens the merge-continuation worker prompt to prevent “schema probe” dispatch_workflow calls that can consume gh-aw’s write-once safe-output budget and discard the real dispatch payload.

Changes:

• Adds explicit WRITE-ONCE guidance forbidding empty/placeholder dispatch_workflow calls and explaining the “first call wins” consequence.
• Names noop as the alternative when no dispatch should occur.
• Adds a Vitest contract asserting the worker prompt contains the anti-probe / write-once guidance.

Show a summary per file

File	Description
workflows/squad-implement-worker.md	Adds write-once / no-schema-probe dispatch guidance for merge continuation.
test/gh-aw-quality.test.ts	Adds a contract test asserting the worker prompt includes the new guidance.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite