Archive 1.10.0 migrations #2518
Conversation
|
I can think of reasons we might want to keep the last N versions around. Was there a discussion and decision that we will archive migrations right away after a release? |
Yes, but wasn't registered anywhere 😿 and it happened too long ago so I don't remember most of the discussion. But we can start a thread now: I do remember that the argument was that we end up spending time (multiplied by all the variants) building artifacts that already exist in the tuf repos. This also affects the github workflows execution time. |
|
I remember the discussion, but I don't remember where. The key realization for me was that archiving the migrations doesn't mean someone can't upgrade from one of those older versions. The migrations are still available, they just aren't rebuilt every time. |
Can you elaborate on some of them? |
I was mostly thinking about development work in which you want to build a repo with a few earlier versions to check migration paths, but I guess you would build from tags for that anyway, so nevermind. |
etungsten
dismissed
their stale review
The container-runtime settings migration needs to be retroactively fixed
|
@stmcginnis created #2523 to fix the migration, I'll remove that migration this PR. |
arnaldo2792
force-pushed
the
archive-1.10-migrations
branch
from
3938df6
to
fc93027
Compare
|
(forced push adds back the 1.10.1 migrations, but I forgot to removed them from archive and add them to |
arnaldo2792
force-pushed
the
archive-1.10-migrations
branch
from
fc93027
to
0e9d942
Compare
|
(forced push adds back v1.10.1 migrations to |
This helps reduce the build time since the build system currently compiles everything in the migrations' directory. Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
arnaldo2792
force-pushed
the
archive-1.10-migrations
branch
from
0e9d942
to
0cb3dfb
Compare
|
(forced push is a rebase onto develop, to make sure I have the fixes in #2523) |
Description of changes:
Regardless of the next release version, archiving migrations improves builds' speed. This is similar to what was done in #2357 and #1699.
Testing done:
Builds are successful after archiving the migrations.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.