Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: archive old migrations before v1.9.1 #2357

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Aug 17, 2022

Issue number:
N/A

Description of changes:
For reference, the previous archiving: #1699. This makes the same change.

See 2ce22f1 for the last time we did this.

Same explanation as before:
These migrations have already been built and released with Bottlerocket
releases and don't need to be built again.  The build system and os package
currently build everything in the migrations directory, which can take a
significant amount of time with unneeded migrations.

Their source is still useful as a reference, and the files are small, so it's
worthwhile keeping them in-tree rather than having to search git history.

Testing done:
Before this change, time to build os, release packages and aws-k8s-1.23 variant: Finished dev [optimized] target(s) in 3m 25s
After this change, time to build os, release packages and aws-k8s-1.23 variant: Finished dev [optimized] target(s) in 1m 58s

Before this change, the contents of the migrations rpm shows:

[ec2-user@ip-172-31-32-162 rpms]$ rpm -qlp bottlerocket-x86_64-migrations-0.0-0.aarch64.rpm         
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations                                                                        
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.3.0_control-container-v0-5-2         
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.3.0_etc-hosts-service    
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.3.0_hostname-affects-etc-hosts
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.4.0_registry-mirror-representation
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.4.2_admin-container-v0-7-3
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.4.2_control-container-v0-5-3
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.5.0_oci-hooks-setting
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.5.0_oci-hooks-setting-metadata
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.5.1_control-container-v0-5-4
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.5.3_vmware-host-containers
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.6.0_aws-admin-container-v0-7-4
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.6.0_aws-control-container-v0-5-5
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.6.0_node-taints-representation
...

After this change, the contents of the migrations rpm is now just the directory and nothing else:

$ rpm -qlp bottlerocket-x86_64-migrations-0.0-0.aarch64.rpm
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

See 2ce22f1 for the last time we did this.

Same explanation as before:
These migrations have already been built and released with Bottlerocket
releases and don't need to be built again.  The build system and os package
currently build everything in the migrations directory, which can take a
significant amount of time with unneeded migrations.

Their source is still useful as a reference, and the files are small, so it's
worthwhile keeping them in-tree rather than having to search git history.
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know we did this previously.

@etungsten etungsten merged commit 0677915 into bottlerocket-os:develop Aug 18, 2022
@etungsten etungsten deleted the archive-old-migrations branch August 18, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants