Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive old migrations #1699

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Aug 6, 2021

For reference, the previous archiving: #1540. This makes the same change.

See also: f5a48c582df43

These migrations have already been built and released with Bottlerocket
releases and don't need to be built again.  The build system and os package
currently build everything in the migrations directory, which can take a
significant amount of time with unneeded migrations.

Their source is still useful as a reference, and the files are small, so it's
worthwhile keeping them in-tree rather than having to search git history.

Testing done:

This took build time of the os package from ~232 seconds down to ~197.

The contents of the migrations rpm went from all current migrations:

> rpm -qlp bottlerocket-x86_64-migrations-0.0-0.x86_64.rpm
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.1.0_kubelet-cloud-provider
...
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.2.0_kubelet-topology-manager

To just the directory, as expected:

> rpm -qlp bottlerocket-x86_64-migrations-0.0-0.x86_64.rpm
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/migrations

I also confirmed the resulting image is still healthy.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

See also: f5a48c5

These migrations have already been built and released with Bottlerocket
releases and don't need to be built again.  The build system and os package
currently build everything in the migrations directory, which can take a
significant amount of time with unneeded migrations.

Their source is still useful as a reference, and the files are small, so it's
worthwhile keeping them in-tree rather than having to search git history.
@tjkirch tjkirch merged commit 3cbe1d8 into bottlerocket-os:develop Aug 6, 2021
@tjkirch tjkirch deleted the archive-old-migrations branch August 6, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants