Add python unit test for triangulation with robust noise model #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Jan 12, 2022
| CameraSetCal3Bundler, PinholeCameraCal3_S2, | ||
| PinholeCameraCal3Bundler, Point2Vector, Point3, Pose3, | ||
| Pose3Vector, Rot3) | ||
| from gtsam import ( |
There was a problem hiding this comment.
Are you using pep8 with Google style? You should :-)
There was a problem hiding this comment.
@dellaert Hi Frank, I just reformatted with yapf --style google. I don't see a match though, with the prior formatting. Do we have a CONTRIBUTING.md with the current official Python formatting guidelines?
| PinholeCameraCal3_S2, | ||
| (K1, K2), | ||
| camera_set=CameraSetCal3_S2) | ||
| measurements, cameras = self.generate_measurements( |
There was a problem hiding this comment.
Only reformat what you add in a PR
|
CI is failing |
passing now : - ) |
|
@johnwlambert looks great! approving post mortem :-) |
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a python unit test equivalent for the C++ tests in @lucacarlone's very nice robust Triangulation PR.