Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert shared pointers in some tests to stack allocated instances #380

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Convert shared pointers in some tests to stack allocated instances #380

merged 4 commits into from
Sep 19, 2023

Conversation

achintyamohan
Copy link
Collaborator

@varunagrawal This should close #14.

Note that there are a few places in these files (serialization tests and adding joints to links) that still need to use shared pointers.

varunagrawal
varunagrawal approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yeah the ones needed for serialization and other special cases can be left as is. Thanks!

@varunagrawal varunagrawal merged commit 87155fb into borglab:master Sep 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert all shared pointers in tests to stack-allocated instances
2 participants
@achintyamohan @varunagrawal