Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert all shared pointers in tests to stack-allocated instances #14

Closed
gchenfc opened this issue Aug 31, 2020 · 1 comment · Fixed by #380
Closed

convert all shared pointers in tests to stack-allocated instances #14

gchenfc opened this issue Aug 31, 2020 · 1 comment · Fixed by #380
Assignees
Labels
easy-fix Easy issue to fix. Good for beginners.

Comments

@gchenfc
Copy link
Member

gchenfc commented Aug 31, 2020

This issue was imported from github.gatech.edu.
The original issue was opened by @smccormick32 on 2020-07-08T15:25:16Z

From review of PR https://github.gatech.edu/borglab/GTDynamics/pull/47, line 65 in testPrismaticJoint.cpp and line 55 in testScrewJoint.cpp. (This is likely also present in testRevoluteJoint.cpp, and may show up in other tests as well.)

Here is an example of what that looks like currently, where j1 is the shared pointer to be converted in this case:

EXPECT(j1->getJointParameters().effort_type == Joint::JointEffortType::Actuated);
@varunagrawal varunagrawal added the easy-fix Easy issue to fix. Good for beginners. label Dec 22, 2021
@varunagrawal
Copy link
Collaborator

List of files this needs to be updated in:

  1. testSdf.cpp
  2. testHelicalJoint.cpp
  3. testPrismaticJoint.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-fix Easy issue to fix. Good for beginners.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants