Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for JDK 17 - Core library #133

Closed
15 of 26 tasks
ekoniec1 opened this issue Jun 10, 2024 · 6 comments · Fixed by boozallen/aissemble-parent#8 or #349
Closed
15 of 26 tasks

Feature: Add support for JDK 17 - Core library #133

ekoniec1 opened this issue Jun 10, 2024 · 6 comments · Fixed by boozallen/aissemble-parent#8 or #349
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ekoniec1
Copy link

ekoniec1 commented Jun 10, 2024

Description

Currently, JDK 11 is required in order to use aiSSEMBLE. OpenJDK support for 11 is ending soon and 17 is well supported across the open source community. For example, JDK 17 is compatible with Spark 3.3+ and even required for Quarkus 3.7+. Upgrading to JDK 17 will allow developers to take advantage of the latest JDK language features, performance improvements, and security fixes.

For this ticket, we will focus to make sure the build succedding until the foundation-messaging module

DOD

  • Allow for JDK 17 to be utilized for building and running aiSSEMBLE pipelines
    • update aissemble-parent to support java 17
    • get the build succeeding up to the module foundation-messaging and all modules should have build success including unit tests and integration-test
      • modules (make sure all dependency modules support java 17)
        • root pom
        • build-parent
        • build-support
          • aissemble-enforcer-extension
        • bom
          • bom-component
          • bom-instantiation
        • foundation
          • foundation-mda-plugins
            • artifacts-maven-plugins
            • foundation-model-plugin
            • mda-maven-plugin
          • foundation-archetype
          • foundation-common
          • foundation-mda
          • foundation-core-java
          • foundation-core-python
          • foundation-messaging
            • foundation-messaging-java
            • foundation-messaging-python
              - [ ] build success
              - [ ] test success
              - [ ] integration test success
              - [ ] make sure all dependency modules support java 17
      • make sure we clean up unused dependency modules
      • All modification should be on the feature branch feature-java17

Test Strategy/Script

  • Run the build with integration test profile and make sure it succeed through foundation-messaging

References/Additional Context

N/A

@ekoniec1 ekoniec1 added the enhancement New feature or request label Jun 10, 2024
@ewilkins-csi ewilkins-csi added this to the 1.8.0 milestone Jun 12, 2024
@peter-mcclonski
Copy link
Contributor

Moved hive-metastore-service docker image from Java 11 to Java 17 as part of #127

@csun-cpointe csun-cpointe modified the milestones: 1.8.0, 1.9.0 Aug 5, 2024
@ewilkins-csi
Copy link
Contributor

Prioritized #263 as a smaller bite of this work

@csun-cpointe csun-cpointe changed the title Feature: Add support for JDK 17 Feature: Add support for JDK 17 - Core library Sep 17, 2024
@csun-cpointe
Copy link
Contributor

DoD completed with @ewilkins-csi @nartieri @carter-cundiff

@csun-cpointe csun-cpointe self-assigned this Sep 17, 2024
csun-cpointe added a commit that referenced this issue Sep 18, 2024
csun-cpointe added a commit that referenced this issue Sep 18, 2024
csun-cpointe added a commit that referenced this issue Sep 18, 2024
@csun-cpointe
Copy link
Contributor

csun-cpointe commented Sep 19, 2024

We decide to cut the ticket and merge in the code since we are already at the stage that we can build through the foundation module. This will also enable parallel work on the upgrade. We will flow follow on ticket to cover rest of the modules.

@ewilkins-csi
Copy link
Contributor

OTS looks good!

@ewilkins-csi
Copy link
Contributor

Final Test passed

  1. mvn clean install -Pintegration-test on branch feature-java17 succeeds up to and including foundation-messaging-java. (Fails at module 33/145 extensions-authzforce-attribute)
    Screenshot 2024-09-19 at 2 53 47 PM

@ewilkins-csi ewilkins-csi modified the milestones: 1.9.0, 1.10.0 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants