#133 upgrade java17 foundation core modules #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
csun-cpointe
force-pushed
the
feature-java17
branch
from
bdd30f6
to
7de77e9
Compare
csun-cpointe
force-pushed
the
133-upgrade-java17-foundation-modules
branch
from
c711e6e
to
c3613b6
Compare
| <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>11</maven.compiler.target> | ||
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> |
There was a problem hiding this comment.
S: Should just inherit these from aissemble-parent
| @@ -70,7 +70,6 @@ | |||
| <version.slf4j>2.0.7</version.slf4j> | |||
| <version.log4j>2.20.0</version.log4j> | |||
| <version.cucumber.reporting.plugin>5.7.5</version.cucumber.reporting.plugin> | |||
| <!-- NB: After Java 17 upgrade, we may not need this --> | |||
There was a problem hiding this comment.
I: Maven plugins still need to use Javax as that ecosystem hasn't made the shift to Jakarta
ewilkins-csi
approved these changes
Sep 19, 2024
csun-cpointe
force-pushed
the
133-upgrade-java17-foundation-modules
branch
from
c3613b6
to
b131b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.