Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Upgrade Drift Detection to Java 17 #426

Closed
8 tasks done
carter-cundiff opened this issue Oct 21, 2024 · 2 comments · Fixed by #427
Closed
8 tasks done

Feature: Upgrade Drift Detection to Java 17 #426

carter-cundiff opened this issue Oct 21, 2024 · 2 comments · Fixed by #427
Assignees
@jacksondelametter
Labels
enhancement New feature or request
Milestone
1.10.0

Comments

@carter-cundiff
Copy link
Contributor

carter-cundiff commented Oct 21, 2024 •
edited by jacksondelametter
Loading

Description

Follow on to #133, where we want to migrate our whole repository to java 17. This issue will focus on migrating drift detection module to enable it within downstream projects.

DOD

  • Update the following submodules to build with JDK 17 and ensure all tests pass
    • foundation-drift-detection
    • foundation-drift-detection-client-java
    • foundation-drift-detection-core-java
    • foundation-drift-detection-engine
    • foundation-drift-detection-service
  • Clean up pom files from the above modules to remove unnecessary dependencies and add undeclared transient dependencies
    • Use mvn dependency:analyze

Test Strategy/Script
@carter-cundiff carter-cundiff added the enhancement New feature or request label Oct 21, 2024
@carter-cundiff carter-cundiff changed the title Feature: Upgrade Data and Model Lineage to Java 17 Feature: Upgrade Drift Detection to Java 17 Oct 21, 2024
@jacksondelametter jacksondelametter self-assigned this Oct 22, 2024
@jacksondelametter jacksondelametter added this to the 1.10.0 milestone Oct 22, 2024
jacksondelametter added a commit that referenced this issue Oct 22, 2024
@jacksondelametter
#426 - Cleaned up drift detection modules pom files and verifies it w…
e6cc7b4 
…orks with JDK 17
@cpointe-ibllanos
Copy link
Contributor

Confirmed over-the-shoulder

jacksondelametter added a commit that referenced this issue Oct 22, 2024
@jacksondelametter
#426 - Cleaned up drift detection modules pom files and verifies it w…
09fe418 
…orks with JDK 17
jacksondelametter added a commit that referenced this issue Oct 22, 2024
@jacksondelametter
#426 - Cleaned up drift detection modules pom files and verifies it w…
df04230 
…orks with JDK 17
jacksondelametter added a commit that referenced this issue Oct 22, 2024
@jacksondelametter
Merge pull request #427 from boozallen/426-drift-detection-jdk17
91857d9 
#426 - Cleaned up drift detection modules pom files and verifies it w…
@cwoods-cpointe
Copy link
Contributor

Final test: GH action completed successfully. Drift detection module built without error.

@carter-cundiff carter-cundiff linked a pull request Oct 24, 2024 that will close this issue
#426 - Cleaned up drift detection modules pom files and verifies it w… #427
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacksondelametter jacksondelametter

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

#426 - Cleaned up drift detection modules pom files and verifies it w… boozallen/aissemble
4 participants
@jacksondelametter @carter-cundiff @cpointe-ibllanos @cwoods-cpointe