Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft release v1.4.10 #2527

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Draft release v1.4.10 #2527

merged 9 commits into from
Jun 21, 2024

Conversation

zzzckck
Copy link
Collaborator

@zzzckck zzzckck commented Jun 21, 2024 •
edited
Loading

Notice:
v1.4.10 solved the "BAD BLOCK" issue after Haber hard fork, pls use this version if your node has the BAD BLOCK issue.

Description

v1.4.10 is a maintenance release, which has several improvements and fixes:

  • improve: performance, MEV-API, less-reorg
  • fix: ethapi, UT failure, rpc:getBlobSidecars, BAD BLOCK caused by nil withdrawals.

There is no compatible change, to upgrade to v1.4.10 from v1.4.x, simply replace the binary should work.

Change Log

FEATURE

  • NA

IMPROVEMENT

  • #2512 feat: add mev helper params and func
  • #2508 perf: speedup pbss trienode read
  • #2509 perf: optimize chain commit performance for multi-database
  • #2451 core/forkchoice: improve stability when inturn block not generate

BUGFIX

  • #2518 fix: remove zero gasprice check for BSC
  • #2519 UT: random failure of TestSnapSyncWithBlobs
  • #2515 fix getBlobSidecars by ethclient
  • #2525 fix: ensure empty withdrawals after cancun before broadcast

Example

NA

Compatibility

NA

irrun and others added 9 commits June 13, 2024 11:13
@irrun
feat: add mev helper params and func (#2512)
f467c60
@will-2012
perf: speedup pbss trienode read (#2508)
99d31ae
@jingjunLi
perf: optimize chain commit performance for multi-database (#2509)
7b08a70
@NathanBSC
core/forkchoice: improve stability when inturn block not generated (#…
00f094c 
…2451)
@zzzckck
fix: remove zero gasprice check for BSC (#2518)
be0fbfb 
note: blobGasFeePrice can not be zero right now.
@zzzckck
UT: random failure of TestSnapSyncWithBlobs (#2519)
6094d71 
this case failed randomly in github CI, the ratio of around 20%
but can not be reproduced locally by:
```
  go test -p 1 -v -run TestSnapSyncWithBlobs -count 100
```
there could be a potential risk between `runEthPeer` and `runSnapExtension`,as
they shared the same handler.peers.
Add extra wait time for `runEthPeer` to resolve it.

And same for another UT: testBroadcastBlock
@zlacfzy
fix getBlobSidecars by ethclient (#2515)
27a3ec5
@NathanBSC
fix: ensure empty withdrawals after cancun before broadcast (#2525)
f2e7f1d
@zzzckck
release: prepare for release v1.4.10 (#2526)
1548452
@zzzckck zzzckck changed the title Develop Draft release v1.4.10 Jun 21, 2024
@zzzckck zzzckck merged commit f0c7795 into master Jun 21, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galaio galaio galaio approved these changes

@buddh0 buddh0 buddh0 approved these changes

@unclezoro unclezoro unclezoro approved these changes

@jingjunLi jingjunLi Awaiting requested review from jingjunLi

@irrun irrun Awaiting requested review from irrun

@zlacfzy zlacfzy Awaiting requested review from zlacfzy

@will-2012 will-2012 Awaiting requested review from will-2012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@zzzckck @unclezoro @buddh0 @galaio @irrun @will-2012 @jingjunLi @NathanBSC @zlacfzy