UT: random failure of TestSnapSyncWithBlobs #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this case failed randomly in github CI, the ratio of around 20% but can not be reproduced locally go test -p 1 -v -run TestSnapSyncWithBlobs -count 100 there could be a potential risk between `runEthPeer` and `runSnapExtension`, as they shared the handler.peers. Add extra wait time for `runEthPeer`
zzzckck
force-pushed
the
fix_ut_TestSnapSyncWithBlobs
branch
from
85bebec
to
72c5a9f
Compare
galaio
approved these changes
Jun 20, 2024
buddh0
approved these changes
Jun 20, 2024
zlacfzy
approved these changes
Jun 20, 2024
This was referenced Jun 21, 2024
Merged
jellyb0y
pushed a commit
to jellyb0y/bsc
that referenced
this pull request
Aug 11, 2024
this case failed randomly in github CI, the ratio of around 20% but can not be reproduced locally by: ``` go test -p 1 -v -run TestSnapSyncWithBlobs -count 100 ``` there could be a potential risk between `runEthPeer` and `runSnapExtension`,as they shared the same handler.peers. Add extra wait time for `runEthPeer` to resolve it. And same for another UT: testBroadcastBlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix issue: #2489
this case failed randomly in github CI, the ratio of around 20%.
but it can not be reproduced locally:
There could be a potential risk between
runEthPeerandrunSnapExtension, as they shared thehandler.peers. Add extra wait time forrunEthPeerAnd also same for UT TestBroadcastBlock3Peers:
Rationale
NA
Example
NA
Changes
NA