Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure empty withdrawals after cancun before broadcast #2525

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: ensure empty withdrawals after cancun before broadcast #2525

merged 1 commit into from
Jun 21, 2024

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Jun 21, 2024 •
edited
Loading

Description

fix: ensure empty withdrawals after cancun before broadcast

Rationale

no matter get a new block directly or by fetching

both need to ensure empty withdrawals after cancun before broadcast

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC NathanBSC changed the title Ensure empty withdrawhash before broadcast fix: ensure empty withdrawals after cancun before broadcast Jun 21, 2024
@NathanBSC NathanBSC force-pushed the ensure_empty_withdrawhash_before_broadcast branch from 232a60e to c65c83e Compare June 21, 2024 03:39
unclezoro
unclezoro requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is necessary to change the code of downloader too?

@NathanBSC
Copy link
Contributor Author

NathanBSC commented Jun 21, 2024 •
edited
Loading

Do you think it is necessary to change the code of downloader too?

It's not necessary IMO

  1. data from downloading will be right
    because the server only response with verified blocks
    such as ServiceGetBlockBodiesQuery
  2. if a client linked to some clients stored blocks with wrong withdrals, and download the bad blocks from them
    then the connect will be dropped, it's ok

@zzzckck zzzckck merged commit f2e7f1d into bnb-chain:develop Jun 21, 2024
7 checks passed
This was referenced Jun 21, 2024
Closed
Merged
Merged
@NathanBSC NathanBSC deleted the ensure_empty_withdrawhash_before_broadcast branch July 25, 2024 07:39
jellyb0y pushed a commit to jellyb0y/bsc that referenced this pull request Aug 11, 2024
@NathanBSC @jellyb0y
fix: ensure empty withdrawals after cancun before broadcast (bnb-chai…
78807ce 
…n#2525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@galaio galaio galaio approved these changes

@zlacfzy zlacfzy zlacfzy approved these changes

@zzzckck zzzckck zzzckck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NathanBSC @unclezoro @galaio @zlacfzy @zzzckck