Replace "Note about sharing" prompt with an inline hint#8452
Merged
Conversation
Contributor
|
estrattonbailey
approved these changes
Jun 6, 2025
Member
estrattonbailey
left a comment
estrattonbailey
left a comment
There was a problem hiding this comment.
Nice!
I think on web, we should rearrange the items though, so that it's:
- Send via DM
- Divider
- Copy link
- Private text (no divider above)
That way it's more contextually related to copying the link.
Member
Author
|
Yeah, that's easy enough, will do |
arcalinea
temporarily deployed
to
samuel/pwi-warning - social-app PR #8452
Render
Destroyed
Member
Author
|
estrattonbailey
added a commit
that referenced
this pull request
Jun 10, 2025
* origin/main: (241 commits) Nightly source-language update Update react-navigation (#5967) Update SetNewPasswordForm.tsx (#8349) Nightly source-language update bskyweb: bump indigo (several codegen updates) (#8442) Replace "Note about sharing" prompt with an inline hint (#8452) Bump version to v1.104 (#8447) show misclass button by the same logic as feedContext (#8445) change fontSize: 15 to a.text_sm (#7896) Nightly source-language update use method that's actually available on android (#8448) Release 1.103.0 prep (#8434) Add language: European Portuguese (`pt-PT`) (#8375) Small test fix tweak ordering of explore components (#8432) add metrics (#8426) invert flag for sending to statsig (#8431) Fix link to like-via-repost (#8428) Nightly source-language update Make via-repost notifs groupable (#8429) ...
uwx
pushed a commit
to chaos-social/chaos-social.github.io
that referenced
this pull request
Jul 11, 2025
…al#8452) * add pwi warning to share menu, remove prompt * add pwi label to web, remove prompt * add an option to the PWI menu * conditionally reorder items on web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer triggers the annoying prompt - just shows an inline notice instead
Also fixed PWI post menu - currently there's zero items that show up there since we moved everything to the share menu, so it looks broken. just added a simple item that triggers the sign in prompt