Skip to content

add metrics#8426

Merged
haileyok merged 6 commits into
mainfrom
hailey/feed-metrics
May 30, 2025
Merged

add metrics#8426
haileyok merged 6 commits into
mainfrom
hailey/feed-metrics

Conversation

@haileyok
Copy link
Copy Markdown
Member

Adding some feed metrics for

  • Post likes (feed context)
  • Post reposts (feed context)
  • Feed pins/unpins/saves/unsaves (feed uri)

Test Plan

Do the events above, and watch to see what gets sent in events.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

Old size New size Diff
7.24 MB 7.24 MB 514 B (0.01%)

@arcalinea arcalinea temporarily deployed to hailey/feed-metrics - social-app PR #8426 May 29, 2025 21:44 — with Render Destroyed
Comment thread src/state/queries/post.ts
>({
mutationFn: ({uri, cid, via}) => {
logEvent('post:repost', {logContext})
logger.metric('post:repost', {logContext, feedDescriptor})
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We good with no longer sending this data to statsig? statsig is now opt-in for logger.metric

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that actually how this works? logEvent is deprecated, and i was under the impression logger.metric was how we do it now (with an option to disable sending to statsig). we want everything to be going to statsig, and we are using logger.metric a lot now, so we'll need to definitely change that if this is the case

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/screens/Search/modules/ExploreTrendingVideos.tsx Outdated
@arcalinea arcalinea temporarily deployed to hailey/feed-metrics - social-app PR #8426 May 30, 2025 18:07 — with Render Destroyed
Copy link
Copy Markdown
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haileyok haileyok merged commit ce7b9dc into main May 30, 2025
7 checks passed
estrattonbailey added a commit that referenced this pull request Jun 10, 2025
* origin/main: (241 commits)
  Nightly source-language update
  Update react-navigation (#5967)
  Update SetNewPasswordForm.tsx (#8349)
  Nightly source-language update
  bskyweb: bump indigo (several codegen updates) (#8442)
  Replace "Note about sharing" prompt with an inline hint (#8452)
  Bump version to v1.104 (#8447)
  show misclass button by the same logic as feedContext (#8445)
  change fontSize: 15 to a.text_sm (#7896)
  Nightly source-language update
  use method that's actually available on android (#8448)
  Release 1.103.0 prep (#8434)
  Add language: European Portuguese (`pt-PT`) (#8375)
  Small test fix
  tweak ordering of explore components (#8432)
  add metrics (#8426)
  invert flag for sending to statsig (#8431)
  Fix link to like-via-repost  (#8428)
  Nightly source-language update
  Make via-repost notifs groupable (#8429)
  ...
uwx pushed a commit to chaos-social/chaos-social.github.io that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants