-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Spell check setting #6446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spell check setting #6446
Conversation
ui/desktop/src/main.ts
Outdated
| } | ||
| }); | ||
|
|
||
| // Handle spellcheck setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i imagine it will give you great satisfaction to remove this comment before merging :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha thanks. to be honest I am wavering. it feels like a fight I am losing and dumb comments aren't as bad as dumb tests maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goose run --text "look at the current branch and compare with main. remove any comments that were introduced that were introduce that just say what the code underneath is doing, i.e. commenting on what or how and not on why."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a user-configurable spellcheck setting to the desktop application, allowing users to enable or disable spellcheck in the chat input field. The change addresses issue #6423.
Changes:
- Added
spellcheckEnabledboolean setting with a default value oftrue - Implemented IPC handlers for getting and setting the spellcheck state
- Created a SpellcheckToggle UI component in the chat settings section
- Applied the spellcheck setting to the BrowserWindow configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/desktop/src/utils/settings.ts | Adds spellcheckEnabled boolean field to Settings interface with default value of true |
| ui/desktop/src/preload.ts | Defines IPC API methods for setSpellcheck and getSpellcheckState |
| ui/desktop/src/main.ts | Applies spellcheck setting to window creation and implements IPC handlers for managing the setting |
| ui/desktop/src/components/settings/chat/SpellcheckToggle.tsx | New toggle component for enabling/disabling spellcheck with user-facing description |
| ui/desktop/src/components/settings/chat/ChatSettingsSection.tsx | Integrates SpellcheckToggle component into chat settings |
Co-authored-by: Douwe Osinga <[email protected]>
…ased * 'main' of github.com:block/goose: (23 commits) Use Intl.NumberFormat for token formatting in SessionsInsights (#6466) feat(ui): format large and small token counts for readability (#6449) fix: apply subrecipes when using slash commands (#6460) Fix: exclude platform_schedule_tool in CLI (#6442) Fix: Small update in how ML-based prompt injection determines final result (#6439) docs: remove SSE transport and rename to Streamable HTTP (#6319) fix: correct Cloudinary extension command and env variable (#6453) fix: add gap between buttons in MacDesktopInstallButtons.js (#6452) refactor: include hidden dotfiles folders in file picker search (#6315) upgraded safe npm packages (#6450) chore(deps): bump react-router and react-router-dom in /ui/desktop (#6408) chore(deps): bump lru from 0.12.5 to 0.16.3 (#6379) chore(deps-dev): bump @modelcontextprotocol/sdk from 1.24.0 to 1.25.2 in /ui/desktop (#6375) fix: inconsistent API url requirement between desktop and CLI versions (#6419) feat(vertexai): Add streaming support (#6409) fix deeplink recipe launch cold start (#6210) Spell check setting (#6446) File bug directly (#6413) fix(cli): incorrect bin name in shell completions (#6444) Use crunchy from crates instead of git fork (#6415) ...
Summary
fixes #6423