-
Notifications
You must be signed in to change notification settings - Fork 2.4k
refactor: include hidden dotfiles folders in file picker search #6315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue #6211 by enabling the file picker to include important configuration directories that start with a dot (hidden folders) in search results, making it possible to reference files like GitHub workflows and VS Code settings.
- Introduces an allowlist approach for hidden directories instead of blanket exclusion
- Removes
.vscodeand.ideafrom the skip list since they're now explicitly allowed - Updates documentation to reflect the new hidden folder support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/desktop/src/components/MentionPopover.tsx | Adds allowedHiddenDirs array with configuration directories (.github, .vscode, .idea, etc.) and modifies filtering logic to check the allowlist before skipping hidden items |
| documentation/docs/guides/file-management.md | Updates file search documentation to remove .vscode and .idea from the auto-filtering list and adds a new bullet point documenting hidden folder support |
Signed-off-by: Abhijay007 <[email protected]>
53f296a to
4296cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Signed-off-by: Abhijay007 <[email protected]>
…k#6315) Signed-off-by: Abhijay007 <[email protected]>
…ased * 'main' of github.com:block/goose: (23 commits) Use Intl.NumberFormat for token formatting in SessionsInsights (#6466) feat(ui): format large and small token counts for readability (#6449) fix: apply subrecipes when using slash commands (#6460) Fix: exclude platform_schedule_tool in CLI (#6442) Fix: Small update in how ML-based prompt injection determines final result (#6439) docs: remove SSE transport and rename to Streamable HTTP (#6319) fix: correct Cloudinary extension command and env variable (#6453) fix: add gap between buttons in MacDesktopInstallButtons.js (#6452) refactor: include hidden dotfiles folders in file picker search (#6315) upgraded safe npm packages (#6450) chore(deps): bump react-router and react-router-dom in /ui/desktop (#6408) chore(deps): bump lru from 0.12.5 to 0.16.3 (#6379) chore(deps-dev): bump @modelcontextprotocol/sdk from 1.24.0 to 1.25.2 in /ui/desktop (#6375) fix: inconsistent API url requirement between desktop and CLI versions (#6419) feat(vertexai): Add streaming support (#6409) fix deeplink recipe launch cold start (#6210) Spell check setting (#6446) File bug directly (#6413) fix(cli): incorrect bin name in shell completions (#6444) Use crunchy from crates instead of git fork (#6415) ...
* main: (41 commits) Allow customizing the new line keybinding in the CLI (#5956) Ask for permission in the CLI (#6475) docs: add Ralph Loop tutorial for multi-model iterative development (#6455) Remove gitignore fallback from gooseignore docs (#6480) fix: clean up result recording for code mode (#6343) fix(code_execution): handle model quirks with tool calls (#6352) feat(ui): support prefersBorder option for MCP Apps (#6465) fixed line breaks (#6459) Use Intl.NumberFormat for token formatting in SessionsInsights (#6466) feat(ui): format large and small token counts for readability (#6449) fix: apply subrecipes when using slash commands (#6460) Fix: exclude platform_schedule_tool in CLI (#6442) Fix: Small update in how ML-based prompt injection determines final result (#6439) docs: remove SSE transport and rename to Streamable HTTP (#6319) fix: correct Cloudinary extension command and env variable (#6453) fix: add gap between buttons in MacDesktopInstallButtons.js (#6452) refactor: include hidden dotfiles folders in file picker search (#6315) upgraded safe npm packages (#6450) chore(deps): bump react-router and react-router-dom in /ui/desktop (#6408) chore(deps): bump lru from 0.12.5 to 0.16.3 (#6379) ...
closes #6211
PR description:
Refactor the file picker to include hidden configuration folders in search results. Previously, all files and folders starting with
.were excluded, making it impossible to reference important configuration files like GitHub workflows, VS Code settings, and other dotfiles.Changes made
Added allowlist for hidden directories: Created
allowedHiddenDirsarray containing important configuration directories:.github- GitHub workflows and actions.vscode- VS Code settingsetc .....
Updated filtering logic: Modified the file picker to check if hidden items are in the allowlist before skipping them, instead of blanket-excluding all dotfiles
Removed from skip list: Removed
.vscodeand.ideafromskipDirssince they're now explicitly allowedDocumentation update: Updated file management guide to document the new hidden folder support
Type of Change
Testing
Tested in the desktop UI
Screenshots/Demos (for UX changes)
Before:
After: