fix: inconsistent API url requirement between desktop and CLI versions #6419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhijay007 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an inconsistency where the desktop version and CLI version of goose required different API URL formats for custom OpenAI-compatible providers. Previously, the desktop and CLI showed /v1/messages as the placeholder, but the actual path construction logic didn't properly handle the standard OpenAI format of /v1 as a base path.
Key changes:
- Updated placeholder text in both desktop UI and CLI to use
/v1instead of/v1/messages - Modified the URL path construction logic in
openai.rsto automatically append/chat/completionsto base paths that don't already have it
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx | Updated placeholder from /v1/messages to /v1 for consistency with OpenAI standard |
| crates/goose-cli/src/commands/configure.rs | Updated placeholder from /v1/messages to /v1 for consistency with OpenAI standard |
| crates/goose/src/providers/openai.rs | Added logic to automatically append /chat/completions to base paths, handling various URL formats (with/without trailing slash, already complete paths) |
DOsinga
reviewed
Jan 9, 2026
Signed-off-by: Abhijay007 <[email protected]>
Signed-off-by: Abhijay007 <[email protected]>
DOsinga
approved these changes
Jan 12, 2026
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 13, 2026
block#6419) Signed-off-by: Abhijay007 <[email protected]>
zanesq
added a commit
that referenced
this pull request
Jan 13, 2026
…ased * 'main' of github.com:block/goose: (23 commits) Use Intl.NumberFormat for token formatting in SessionsInsights (#6466) feat(ui): format large and small token counts for readability (#6449) fix: apply subrecipes when using slash commands (#6460) Fix: exclude platform_schedule_tool in CLI (#6442) Fix: Small update in how ML-based prompt injection determines final result (#6439) docs: remove SSE transport and rename to Streamable HTTP (#6319) fix: correct Cloudinary extension command and env variable (#6453) fix: add gap between buttons in MacDesktopInstallButtons.js (#6452) refactor: include hidden dotfiles folders in file picker search (#6315) upgraded safe npm packages (#6450) chore(deps): bump react-router and react-router-dom in /ui/desktop (#6408) chore(deps): bump lru from 0.12.5 to 0.16.3 (#6379) chore(deps-dev): bump @modelcontextprotocol/sdk from 1.24.0 to 1.25.2 in /ui/desktop (#6375) fix: inconsistent API url requirement between desktop and CLI versions (#6419) feat(vertexai): Add streaming support (#6409) fix deeplink recipe launch cold start (#6210) Spell check setting (#6446) File bug directly (#6413) fix(cli): incorrect bin name in shell completions (#6444) Use crunchy from crates instead of git fork (#6415) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6354
PR descripton
This PR fixes an inconsistency where the desktop version and CLI version of goose required different API URL formats for custom OpenAI-compatible providers. Previously, the desktop and CLI showed /v1/messages as the placeholder, but the actual path construction logic didn't properly handle the standard OpenAI format of /v1 as a base path.
Type of Change
AI Assistance