Skip to content

Conversation

@aharvard
Copy link
Collaborator

@aharvard aharvard commented Jan 7, 2026

Summary

Fixes #6364

The draft spec SEP-1865 expects _meta.ui.resourceUri (nested object structure) but goose was expecting _meta['ui/resourceUri'] (flat key with slash), which prevented MCP Apps UI from rendering.

Changes

Updated ui/desktop/src/components/ToolCallWithResponse.tsx to use the correct nested format:

  • Changed UiMeta type from flat key to nested structure
  • Updated maybeRenderMCPApp function to access _meta?.ui?.resourceUri instead of _meta?.['ui/resourceUri']

Testing

  • TypeScript compiles without errors
  • ESLint passes

…865)

Fixes #6364

The draft spec SEP-1865 expects `_meta.ui.resourceUri` (nested object) but
goose was expecting `_meta['ui/resourceUri']` (flat key with slash), which
prevented MCP Apps UI from rendering.

Updated ToolCallWithResponse.tsx to use the correct nested format.
@aharvard aharvard marked this pull request as ready for review January 7, 2026 14:23
Copilot AI review requested due to automatic review settings January 7, 2026 14:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MCP Apps _meta.ui.resourceUri format to match the draft spec SEP-1865, changing from a flat key structure ('ui/resourceUri') to a nested object structure (ui.resourceUri).

Key Changes

  • Introduced UiMeta type with nested structure for better type safety
  • Updated maybeRenderMCPApp function to access _meta?.ui?.resourceUri using the nested format

@DOsinga
Copy link
Collaborator

DOsinga commented Jan 7, 2026

how come this worked with the mcp servers we tested before?

@aharvard
Copy link
Collaborator Author

aharvard commented Jan 7, 2026

how come this worked with the mcp servers we tested before?

Because both the servers and goose were based on an earlier iteration of the draft spec.

Refer to deprecation note here https://github.com/modelcontextprotocol/ext-apps/blob/main/specification/draft/apps.mdx#resource-discovery
image

@DOsinga
Copy link
Collaborator

DOsinga commented Jan 7, 2026

should we support both for now?

@aharvard
Copy link
Collaborator Author

aharvard commented Jan 7, 2026

should we support both for now?

no, I don't think we need to.

@alexhancock alexhancock merged commit 847cabb into main Jan 7, 2026
25 checks passed
@alexhancock alexhancock deleted the fix/mcp-ui-resource-uri-meta-key branch January 7, 2026 19:53
aharvard added a commit that referenced this pull request Jan 7, 2026
* main:
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
zanesq added a commit that referenced this pull request Jan 8, 2026
* 'main' of github.com:block/goose:
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374)
michaelneale added a commit that referenced this pull request Jan 8, 2026
* main: (31 commits)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374)
  fix: Show platform-specific keyboard shortcuts in UI (#6323)
  fix: we load extensions when agent starts so don't do it up front (#6350)
  docs: credit HumanLayer in RPI tutorial (#6365)
  Blog: Goose Lands MCP Apps (#6172)
  Claude 3.7 is out. we had some harcoded stuff (#6197)
  ...
wpfleger96 added a commit that referenced this pull request Jan 9, 2026
* main: (89 commits)
  fix(google): treat signed text as regular content in streaming (#6400)
  Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399)
  fix(ci): add missing dependencies to openapi-schema-check job (#6367)
  feat: http proxy support
  Add support for changing working dir and extensions in same window/session (#6057)
  Sort keys in canonical models (#6403)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  ...
wpfleger96 added a commit that referenced this pull request Jan 9, 2026
* main: (89 commits)
  fix(google): treat signed text as regular content in streaming (#6400)
  Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399)
  fix(ci): add missing dependencies to openapi-schema-check job (#6367)
  feat: http proxy support
  Add support for changing working dir and extensions in same window/session (#6057)
  Sort keys in canonical models (#6403)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  ...
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metadata format mismatch for MCP Apps stops UI from rendering

4 participants