Skip to content

Conversation

@Abhijay007
Copy link
Collaborator

@Abhijay007 Abhijay007 commented Jan 3, 2026

closes #5540

PR Description

This PR adds platform-specific keyboard shortcut display logic to the desktop UI, detecting whether the user is on Mac or Windows/Linux and showing the appropriate modifier keys (⌘ for Mac, Ctrl for Windows/Linux).

Changes made :

  • Created a utility module for platform detection and keyboard shortcut text generation
  • Updated UI text across multiple views to dynamically display the correct keyboard shortcuts based on the user's platform
  • Replaced hardcoded shortcut text with function calls for navigation and search shortcuts

Type of Change

  • Fix

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Tested on Windows on the desktop UI

Screenshots/Demos (for UX changes)

Before: (Windows)

image

After: (Windows)

image

Copilot AI review requested due to automatic review settings January 3, 2026 17:31
@Abhijay007 Abhijay007 marked this pull request as draft January 3, 2026 17:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds platform-specific keyboard shortcut display logic to the desktop UI, detecting whether the user is on Mac or Windows/Linux and showing the appropriate modifier keys (⌘ for Mac, Ctrl for Windows/Linux).

  • Created a utility module for platform detection and keyboard shortcut text generation
  • Updated UI text across multiple views to dynamically display the correct keyboard shortcuts based on the user's platform
  • Replaced hardcoded shortcut text with function calls for navigation and search shortcuts

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ui/desktop/src/utils/keyboardShortcuts.ts New utility module with platform detection and functions to generate platform-specific shortcut text
ui/desktop/src/components/sessions/SessionListView.tsx Uses dynamic search shortcut text instead of hardcoded "⌘F/Ctrl+F"
ui/desktop/src/components/recipes/RecipesView.tsx Uses dynamic search shortcut text instead of hardcoded "⌘F/Ctrl+F"
ui/desktop/src/components/extensions/ExtensionsView.tsx Uses dynamic search shortcut text instead of hardcoded "⌘F/Ctrl+F"
ui/desktop/src/components/ChatInput.tsx Uses dynamic navigation shortcut text instead of hardcoded "⌘↑/⌘↓"

@Abhijay007 Abhijay007 force-pushed the fix/KeyboardShortcuts branch 2 times, most recently from 7c213a5 to af1df9f Compare January 5, 2026 16:38
@Abhijay007 Abhijay007 marked this pull request as ready for review January 5, 2026 16:50
Copilot AI review requested due to automatic review settings January 5, 2026 16:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@alexhancock
Copy link
Collaborator

@Abhijay007 rebase and then LGTM to merge

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
@Abhijay007 Abhijay007 force-pushed the fix/KeyboardShortcuts branch from 40f1119 to c18d560 Compare January 7, 2026 14:55
@Abhijay007 Abhijay007 merged commit 76bf1d0 into block:main Jan 7, 2026
18 checks passed
michaelneale added a commit that referenced this pull request Jan 8, 2026
* main: (31 commits)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374)
  fix: Show platform-specific keyboard shortcuts in UI (#6323)
  fix: we load extensions when agent starts so don't do it up front (#6350)
  docs: credit HumanLayer in RPI tutorial (#6365)
  Blog: Goose Lands MCP Apps (#6172)
  Claude 3.7 is out. we had some harcoded stuff (#6197)
  ...
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust copy for Windows where it mentions mac specific things

2 participants