-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: Show platform-specific keyboard shortcuts in UI #6323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds platform-specific keyboard shortcut display logic to the desktop UI, detecting whether the user is on Mac or Windows/Linux and showing the appropriate modifier keys (⌘ for Mac, Ctrl for Windows/Linux).
- Created a utility module for platform detection and keyboard shortcut text generation
- Updated UI text across multiple views to dynamically display the correct keyboard shortcuts based on the user's platform
- Replaced hardcoded shortcut text with function calls for navigation and search shortcuts
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/desktop/src/utils/keyboardShortcuts.ts | New utility module with platform detection and functions to generate platform-specific shortcut text |
| ui/desktop/src/components/sessions/SessionListView.tsx | Uses dynamic search shortcut text instead of hardcoded "⌘F/Ctrl+F" |
| ui/desktop/src/components/recipes/RecipesView.tsx | Uses dynamic search shortcut text instead of hardcoded "⌘F/Ctrl+F" |
| ui/desktop/src/components/extensions/ExtensionsView.tsx | Uses dynamic search shortcut text instead of hardcoded "⌘F/Ctrl+F" |
| ui/desktop/src/components/ChatInput.tsx | Uses dynamic navigation shortcut text instead of hardcoded "⌘↑/⌘↓" |
7c213a5 to
af1df9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
|
@Abhijay007 rebase and then LGTM to merge |
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
40f1119 to
c18d560
Compare
* main: (31 commits) added validation and debug for invalid call tool result (#6368) Update MCP apps tutorial: fix _meta structure and version prereq (#6404) Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374) fix: Show platform-specific keyboard shortcuts in UI (#6323) fix: we load extensions when agent starts so don't do it up front (#6350) docs: credit HumanLayer in RPI tutorial (#6365) Blog: Goose Lands MCP Apps (#6172) Claude 3.7 is out. we had some harcoded stuff (#6197) ...
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
closes #5540
PR Description
This PR adds platform-specific keyboard shortcut display logic to the desktop UI, detecting whether the user is on Mac or Windows/Linux and showing the appropriate modifier keys (⌘ for Mac, Ctrl for Windows/Linux).
Changes made :
Type of Change
AI Assistance
Testing
Tested on Windows on the desktop UI
Screenshots/Demos (for UX changes)
Before: (Windows)
After: (Windows)