fix(google): treat signed text as regular content in streaming #6400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi
force-pushed
the
2.5-pro
branch
2 times, most recently
from
bd41b85 to
7ccce2f
Compare
Change streaming to use SignedTextAsRegularText instead of SkipSignedText. Signatures are tracked via last_signature and attached to function calls through effective_signature = signature.or(last_signature). Gemini 2.5 models include thoughtSignature on the first streaming chunk regardless of whether function calls follow. The old SkipSignedText behavior discarded text parts with signatures, causing content loss. Signature placement by model: - Gemini 2.5: first part (with or without function calls) - Gemini 3 with function calls: first function call part - Gemini 3 without function calls: last part if thought generated Signed-off-by: rabi <[email protected]>
Contributor
Author
|
@jamadeo Hey! PTAL. This would fix a unique behavior of Gemini 2.5 models. |
jamadeo
approved these changes
Jan 9, 2026
wpfleger96
added a commit
that referenced
this pull request
Jan 9, 2026
* main: (89 commits) fix(google): treat signed text as regular content in streaming (#6400) Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399) fix(ci): add missing dependencies to openapi-schema-check job (#6367) feat: http proxy support Add support for changing working dir and extensions in same window/session (#6057) Sort keys in canonical models (#6403) added validation and debug for invalid call tool result (#6368) Update MCP apps tutorial: fix _meta structure and version prereq (#6404) Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) ...
wpfleger96
added a commit
that referenced
this pull request
Jan 9, 2026
* main: (89 commits) fix(google): treat signed text as regular content in streaming (#6400) Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399) fix(ci): add missing dependencies to openapi-schema-check job (#6367) feat: http proxy support Add support for changing working dir and extensions in same window/session (#6057) Sort keys in canonical models (#6403) added validation and debug for invalid call tool result (#6368) Update MCP apps tutorial: fix _meta structure and version prereq (#6404) Fixed fonts (#6389) Update confidence levels prompt injection detection to reduce false positive rates (#6390) Add ML-based prompt injection detection (#5623) docs: update custom extensions tutorial (#6388) fix ResultsFormat error when loading old sessions (#6385) docs: add MCP Apps tutorial and documentation updates (#6384) changed z-index to make sure the search highlighter does not appear on modal overlay (#6386) Handling special claude model response in github copilot provider (#6369) fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378) fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372) feat(providers): add streaming support for Google Gemini provider (#6191) Blog: edit links in mcp apps post (#6371) ...
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 13, 2026
…#6400) Signed-off-by: rabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change streaming to use SignedTextAsRegularText instead of SkipSignedText. Signatures are tracked via last_signature and attached to function calls through effective_signature = signature.or(last_signature).
Gemini 2.5 models include thoughtSignature on the first streaming chunk regardless of whether function calls follow. The old SkipSignedText behavior discarded text parts with signatures, causing content loss.
Signature placement by model:
Type of Change
AI Assistance
Testing
Unit test and tested with 2.5 models locally to verify the fix for their unique behaviour.