Lifei/UI parameter input #5222

lifeizhou-ap · 2025-10-17T00:19:22Z

Summary

Moves recipe template rendering logic from client (UI) to server side
Consolidates recipe parameter handling into a unified server-side approach
Simplifies the client-side recipe management code

Changes

Removed endpoints:
- /agent/add_sub_recipes
- /agent/prompt
- /agent/session_config
New endpoint:
- /agent/update_from_session - unified endpoint that reads session data and updates agent accordingly
Modified endpoint:
- /session/{session_id}/user_recipe_values - now returns the resolved recipe after parameter substitution, and update agent
Moved the desktop prompts to server side: desktop_prompt.md and desktop_recipe_instruction.md

Type of Change

…meters to recipeParameterValues

…user ui experience

…to server side

zanesq

Front end looks good, verified all recipe paths are working in the current non ALPHA path.

zanesq · 2025-10-18T20:48:40Z

I noticed that I'm getting these key missing errors in the server console logs for a pre-existing recipe that loaded before this change.

18T20:45:34.042098Z ERROR goose::recipe::local_recipes: Failed to load recipe from file /Users/zane/.config/goose/recipes/strategic-account-manager-book-of-business-analysis-updated.yaml: Failed to parse nested recipe: missing field `key`
    at crates/goose/src/recipe/local_recipes.rs:130

* main: (32 commits) turn off WAL (#5203) Skip subagents for gemini (#5257) Revert "Standardize Session Name Attribute" (#5250) improve provider request logging a bit (#5236) Fix OpenAI empty choices panic (#5248) Revert "Rewrite extension management tools" (#5243) Standardize Session Name Attribute (#5085) Docs: Include step-by-step model configuration instructions for first… (#5239) Delete message visibility filter (#5216) delete flaky pricing integration tests (#5207) chore: upgrade most npm packages to latest (#5185) Release/1.11.0 (#5224) Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) ...

lifeizhou-ap · 2025-10-19T22:46:46Z

I noticed that I'm getting these key missing errors in the server console logs for a pre-existing recipe that loaded before this change.
18T20:45:34.042098Z ERROR goose::recipe::local_recipes: Failed to load recipe from file /Users/zane/.config/goose/recipes/strategic-account-manager-book-of-business-analysis-updated.yaml: Failed to parse nested recipe: missing field `key`
    at crates/goose/src/recipe/local_recipes.rs:130

Thank you @zanesq for review and testing! When rendering the recipe list in the library, if the recipe is not valid, it will log the error and ignore this recipe in the list. I guess the recipe might be invalid. I'll reach out to you to get the recipe content.

michaelneale · 2025-10-20T00:34:37Z

can you say why

/agent/prompt

was removed?

* main: Lifei/UI parameter input (#5222) turn off WAL (#5203) Skip subagents for gemini (#5257) Revert "Standardize Session Name Attribute" (#5250) improve provider request logging a bit (#5236) Fix OpenAI empty choices panic (#5248) Revert "Rewrite extension management tools" (#5243)

lifeizhou-ap · 2025-10-20T02:21:36Z

I noticed that I'm getting these key missing errors in the server console logs for a pre-existing recipe that loaded before this change.
18T20:45:34.042098Z ERROR goose::recipe::local_recipes: Failed to load recipe from file /Users/zane/.config/goose/recipes/strategic-account-manager-book-of-business-analysis-updated.yaml: Failed to parse nested recipe: missing field `key`
    at crates/goose/src/recipe/local_recipes.rs:130
Thank you @zanesq for review and testing! When rendering the recipe list in the library, if the recipe is not valid, it will log the error and ignore this recipe in the list. I guess the recipe might be invalid. I'll reach out to you to get the recipe content.

Update: It turns out the recipe is invalid. key is missing for parameters

lifeizhou-ap · 2025-10-20T02:22:08Z

can you say why
/agent/prompt
was removed?

Yes, it was removed in this PR. When start the agent, the desktop prompt are set up at the server side now. After this change, i found there is no place on the frontend calling extend prompt endpoint any more, then I removed it

* 'main' of github.com:block/goose: docs: provide more clarity in tagging step of releases (#5269) docs: add GOOSE_DEBUG environment variable (#5265) Lifei/UI parameter input (#5222) turn off WAL (#5203) Skip subagents for gemini (#5257) Revert "Standardize Session Name Attribute" (#5250) improve provider request logging a bit (#5236) Fix OpenAI empty choices panic (#5248) Revert "Rewrite extension management tools" (#5243) Standardize Session Name Attribute (#5085) Docs: Include step-by-step model configuration instructions for first… (#5239) Delete message visibility filter (#5216) delete flaky pricing integration tests (#5207) chore: upgrade most npm packages to latest (#5185) Release/1.11.0 (#5224)

* main: (40 commits) Fix extension manager resource deadlock (#5066) add new prompt for memory extension (#4945) feat: Stable system prompt and tool ordering for more cache hits (#5192) Remove gtag analytics error (#5268) Feat/smart task organizer recipe (#5032) docs: `goose recipe open` command (#5264) docs: provide more clarity in tagging step of releases (#5269) docs: add GOOSE_DEBUG environment variable (#5265) Lifei/UI parameter input (#5222) turn off WAL (#5203) Skip subagents for gemini (#5257) Revert "Standardize Session Name Attribute" (#5250) improve provider request logging a bit (#5236) Fix OpenAI empty choices panic (#5248) Revert "Rewrite extension management tools" (#5243) Standardize Session Name Attribute (#5085) Docs: Include step-by-step model configuration instructions for first… (#5239) Delete message visibility filter (#5216) delete flaky pricing integration tests (#5207) chore: upgrade most npm packages to latest (#5185) ...

* main: Lifei/UI parameter input (#5222) turn off WAL (#5203) Skip subagents for gemini (#5257) Revert "Standardize Session Name Attribute" (#5250) improve provider request logging a bit (#5236) Fix OpenAI empty choices panic (#5248)

DOsinga · 2025-10-21T15:40:44Z

I'm guessing @michaelneale is using it for his wild experimentation. let's discuss

lifeizhou-ap added 18 commits October 16, 2025 10:29

removed complicated filterValidRecipeParameters and rename recipePara…

4633193

…meters to recipeParameterValues

rename useRecipeManager recipeParameterValues

5304c40

removed redundant check

ae21100

changed the build recipe from template function signature

69809d9

fixed fmt and lint

4f43bff

return resolved recipe when submit parameter values from ui

c1f2023

added resolvedRecipe to render initial prompt on ui

8591a58

moved extractTemplateVariables to RecipeFormField component only for …

b7a090e

…user ui experience

removed updateSystemPrompt after recipe is resolved. moved the logic …

88ef814

…to server side

update from session (WIP)

835b6c0

fixed rendering bug

a9b5f98

call update from session from ui

e336ef0

fixed server side logic

2d5fed1

fixed the unnecessary render template

7da6391

fixed the test

da0fd82

deleted unused endpoint

85d622f

refactored server side and fixed lint

02742c2

cleanup

73f7fc5

lifeizhou-ap marked this pull request as ready for review October 17, 2025 09:40

zanesq approved these changes Oct 18, 2025

View reviewed changes

lifeizhou-ap added 2 commits October 20, 2025 09:40

fixed merge conflicts

3aa17a4

lifeizhou-ap merged commit 8b53a56 into main Oct 19, 2025
11 checks passed

lifeizhou-ap deleted the lifei/ui-parameter-input branch October 19, 2025 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Lifei/UI parameter input #5222

Lifei/UI parameter input #5222

Uh oh!

lifeizhou-ap commented Oct 17, 2025 •

edited

Loading

Uh oh!

zanesq left a comment

Uh oh!

zanesq commented Oct 18, 2025

Uh oh!

lifeizhou-ap commented Oct 19, 2025

Uh oh!

Uh oh!

michaelneale commented Oct 20, 2025

Uh oh!

lifeizhou-ap commented Oct 20, 2025

Uh oh!

lifeizhou-ap commented Oct 20, 2025

Uh oh!

DOsinga commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Lifei/UI parameter input #5222

Lifei/UI parameter input #5222

Uh oh!

Conversation

lifeizhou-ap commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of Change

Uh oh!

zanesq left a comment

Choose a reason for hiding this comment

Uh oh!

zanesq commented Oct 18, 2025

Uh oh!

lifeizhou-ap commented Oct 19, 2025

Uh oh!

Uh oh!

michaelneale commented Oct 20, 2025

Uh oh!

lifeizhou-ap commented Oct 20, 2025

Uh oh!

lifeizhou-ap commented Oct 20, 2025

Uh oh!

DOsinga commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lifeizhou-ap commented Oct 17, 2025 •

edited

Loading