Skip to content

Conversation

@zanesq
Copy link
Collaborator

@zanesq zanesq commented Oct 16, 2025

Problem

PR #4832 lowercased 'Goose' everywhere, but this is causing issues with:

  • Case-sensitive filesystems breaking CI workflows
  • Shortcuts and integrations expecting uppercase name
  • Platform conventions (macOS .app bundles typically use Title Case)

Solution

This PR reverts only the built application names to use uppercase 'Goose' while keeping the lowercase branding in documentation and user-facing text.

Changes

  • ui/desktop/package.json: productName back to 'Goose'
  • All workflow files: paths and artifact names use Goose-* format
  • macOS: Goose.app instead of goose.app
  • Windows: Goose.exe instead of goose.exe
  • Artifact names: Goose-darwin-arm64, Goose-darwin-x64, Goose-win32-x64, Goose-linux-x64

Testing

  • ✅ Verified JSON syntax in package.json
  • ✅ Ran cargo fmt check
  • ✅ Verified no trailing whitespace or syntax errors

This ensures compatibility with existing tooling and platform expectations while maintaining the lowercase branding initiative for user-facing content.

PR #4832 lowercased 'Goose' everywhere, but this is causing issues:
- Case-sensitive filesystems breaking CI workflows
- Shortcuts and integrations expecting uppercase name
- Inconsistent with platform conventions (macOS .app bundles)

This commit reverts only the built application names to use uppercase 'Goose'
while keeping the lowercase branding in documentation and user-facing text.

Changes:
- ui/desktop/package.json: productName back to 'Goose'
- All workflow files: paths and artifact names use Goose-* format
- macOS: Goose.app instead of goose.app
- Windows: Goose.exe instead of goose.exe
- Artifact names: Goose-darwin-arm64, Goose-darwin-x64, Goose-win32-x64, Goose-linux-x64

This ensures compatibility with existing tooling and platform expectations.
- Update githubUpdater.ts to use uppercase Goose for asset names
- Update MacDesktopInstallButtons.js download URLs
- Update WindowsDesktopInstallButtons.js download URLs
- Ensures consistency with built app name changes
@zanesq zanesq requested a review from a team as a code owner October 16, 2025 16:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-10-16 20:14 UTC

- Fix pr-comment-bundle-windows.yml artifact name mismatch (desktop-windows-dist → Goose-win32-x64)
- Fix Windows instructions to use Goose.exe instead of goose.exe
- Update release workflows to use explicit Goose*.zip pattern instead of goose*.zip
- Updates release.yml, canary.yml, and nightly.yml for consistency
@Abhijay007
Copy link
Collaborator

We might need to release a new version to test this change, maybe 1.10.3, to make it able to available to update in Goose

@zanesq zanesq requested review from DOsinga and alexhancock October 16, 2025 16:21
The desktop entry files (forge.deb.desktop and forge.rpm.desktop) expect
uppercase Goose binary names:
- DEB: /usr/lib/goose/Goose
- RPM: /usr/lib/Goose/Goose

The forge.config.ts had lowercase 'goose' which would create a mismatch
and break Linux package installations. Reverting to uppercase 'Goose'
to match the desktop entry files.
@zanesq zanesq marked this pull request as draft October 16, 2025 16:37
@zanesq zanesq marked this pull request as ready for review October 16, 2025 19:34
Copy link
Collaborator

@jamadeo jamadeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break when 1.10+ users try to auto-update, but we've accepted that we need to break it for someone.

@jamadeo jamadeo merged commit f0da14b into main Oct 16, 2025
12 checks passed
@jamadeo jamadeo deleted the fix/revert-uppercase-goose-app-name branch October 16, 2025 20:11
katzdave added a commit that referenced this pull request Oct 16, 2025
* 'main' of github.com:block/goose:
  Break compaction back into check_ and do_ compaction (#5212)
  fix: revert built app name to uppercase Goose (#5206)
  feat: add Code Documentation Generator recipe (#5121) (#5125)
  Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209)
@alexhancock alexhancock mentioned this pull request Oct 17, 2025
michaelneale added a commit that referenced this pull request Oct 17, 2025
* main: (119 commits)
  Break compaction back into check_ and do_ compaction (#5212)
  fix: revert built app name to uppercase Goose (#5206)
  feat: add Code Documentation Generator recipe (#5121) (#5125)
  Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209)
  Blog: Best Practices for Prompt Engineering with goose (#5204)
  force WAL sync after session create (#5202)
  Feat: goose Apify MCP integration docs (#5047)
  feat: enhance goose to search sessions for easy recall (#5177)
  Skip hidden & real format (#5194)
  docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184)
  docs: prompt injection detection (#5193)
  Fix mcp large response race condition (#5065)
  Compaction overhaul (#5186)
  fix: #3960 better approach to input schema for dynamic task params (#5189)
  used recipe id or deeplink to start agent (#5154)
  [docs] Add Blog Post: "Designing AI for Users, Not Just LLMs" (#5190)
  docs: update cognee, jetbrains, mbot extensions config (#5172)
  Minimally disable subagents when not in autonomous model (#5149)
  Fix provider sort (#5188)
  blog: Getting Started with Goose on Windows (#5156)
  ...
michaelneale added a commit that referenced this pull request Oct 17, 2025
* main: (143 commits)
  Break compaction back into check_ and do_ compaction (#5212)
  fix: revert built app name to uppercase Goose (#5206)
  feat: add Code Documentation Generator recipe (#5121) (#5125)
  Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209)
  Blog: Best Practices for Prompt Engineering with goose (#5204)
  force WAL sync after session create (#5202)
  Feat: goose Apify MCP integration docs (#5047)
  feat: enhance goose to search sessions for easy recall (#5177)
  Skip hidden & real format (#5194)
  docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184)
  docs: prompt injection detection (#5193)
  Fix mcp large response race condition (#5065)
  Compaction overhaul (#5186)
  fix: #3960 better approach to input schema for dynamic task params (#5189)
  used recipe id or deeplink to start agent (#5154)
  [docs] Add Blog Post: "Designing AI for Users, Not Just LLMs" (#5190)
  docs: update cognee, jetbrains, mbot extensions config (#5172)
  Minimally disable subagents when not in autonomous model (#5149)
  Fix provider sort (#5188)
  blog: Getting Started with Goose on Windows (#5156)
  ...
anthonydmays pushed a commit to anthonydmays/goose that referenced this pull request Oct 17, 2025
zanesq added a commit that referenced this pull request Oct 17, 2025
* 'main' of github.com:block/goose: (22 commits)
  Rewrite extension management tools (#5057)
  fix: re-sync package-lock.json (#5235)
  docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150)
  feat: add schedule button to recipe entries (#5217)
  Autocompact threshold UI cleanup (#5232)
  fix: correct schema for openai tools (#5229)
  Break compaction back into check_ and do_ compaction (#5212)
  fix: revert built app name to uppercase Goose (#5206)
  feat: add Code Documentation Generator recipe (#5121) (#5125)
  Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209)
  Blog: Best Practices for Prompt Engineering with goose (#5204)
  force WAL sync after session create (#5202)
  Feat: goose Apify MCP integration docs (#5047)
  feat: enhance goose to search sessions for easy recall (#5177)
  Skip hidden & real format (#5194)
  docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184)
  docs: prompt injection detection (#5193)
  Fix mcp large response race condition (#5065)
  Compaction overhaul (#5186)
  fix: #3960 better approach to input schema for dynamic task params (#5189)
  ...
wpfleger96 added a commit to wpfleger96/goose that referenced this pull request Oct 17, 2025
* main:
  delete flaky pricing integration tests (block#5207)
  chore: upgrade most npm packages to latest (block#5185)
  Release/1.11.0 (block#5224)
  Rewrite extension management tools (block#5057)
  fix: re-sync package-lock.json (block#5235)
  docs: Hacktoberfest MCP youtube short entry to community-content.json (block#5150)
  feat: add schedule button to recipe entries (block#5217)
  Autocompact threshold UI cleanup (block#5232)
  fix: correct schema for openai tools (block#5229)
  Break compaction back into check_ and do_ compaction (block#5212)
  fix: revert built app name to uppercase Goose (block#5206)
  feat: add Code Documentation Generator recipe (block#5121) (block#5125)
tlongwell-block added a commit that referenced this pull request Oct 18, 2025
* origin/main: (66 commits)
  Revert "Rewrite extension management tools" (#5243)
  Standardize Session Name Attribute (#5085)
  Docs: Include step-by-step model configuration instructions for first… (#5239)
  Delete message visibility filter (#5216)
  delete flaky pricing integration tests (#5207)
  chore: upgrade most npm packages to latest (#5185)
  Release/1.11.0 (#5224)
  Rewrite extension management tools (#5057)
  fix: re-sync package-lock.json (#5235)
  docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150)
  feat: add schedule button to recipe entries (#5217)
  Autocompact threshold UI cleanup (#5232)
  fix: correct schema for openai tools (#5229)
  Break compaction back into check_ and do_ compaction (#5212)
  fix: revert built app name to uppercase Goose (#5206)
  feat: add Code Documentation Generator recipe (#5121) (#5125)
  Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209)
  Blog: Best Practices for Prompt Engineering with goose (#5204)
  force WAL sync after session create (#5202)
  Feat: goose Apify MCP integration docs (#5047)
  ...
lifeizhou-ap added a commit that referenced this pull request Oct 19, 2025
* main: (32 commits)
  turn off WAL (#5203)
  Skip subagents for gemini (#5257)
  Revert "Standardize Session Name Attribute" (#5250)
  improve provider request logging a bit (#5236)
  Fix OpenAI empty choices panic (#5248)
  Revert "Rewrite extension management tools" (#5243)
  Standardize Session Name Attribute (#5085)
  Docs: Include step-by-step model configuration instructions for first… (#5239)
  Delete message visibility filter (#5216)
  delete flaky pricing integration tests (#5207)
  chore: upgrade most npm packages to latest (#5185)
  Release/1.11.0 (#5224)
  Rewrite extension management tools (#5057)
  fix: re-sync package-lock.json (#5235)
  docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150)
  feat: add schedule button to recipe entries (#5217)
  Autocompact threshold UI cleanup (#5232)
  fix: correct schema for openai tools (#5229)
  Break compaction back into check_ and do_ compaction (#5212)
  fix: revert built app name to uppercase Goose (#5206)
  ...
zanesq added a commit that referenced this pull request Oct 20, 2025
The goose-x86_64-pc-windows-gnu.zip artifact was excluded from releases
starting in v1.10.3 due to a case-sensitive pattern change in the release
workflow.

In commit 5b58b73 (PR #5206), the artifact pattern was changed from
'goose*.zip' to 'Goose*.zip' to match the desktop app naming convention.
However, this inadvertently excluded the Windows CLI build which uses
lowercase 'goose-x86_64-pc-windows-gnu.zip'.

This fix adds 'goose-*.zip' pattern alongside 'Goose*.zip' to ensure
both CLI and desktop Windows builds are included in releases.

Fixes the issue where Windows GNU CLI builds were missing from:
- v1.10.3
- v1.11.0
- v1.11.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants