fix : enhance fuzzy file search in goose desktop #5071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhijay007 <[email protected]>
DOsinga
approved these changes
Oct 8, 2025
| let startPath = window.appConfig.get('GOOSE_WORKING_DIR') as string; | ||
|
|
||
| if (!startPath) { | ||
| startPath = '/Users'; // Default to macOS |
| if (fullPathMatch.score > bestMatch.score) { | ||
| bestMatch = fullPathMatch; | ||
| matchedText = file.path; | ||
| } |
Collaborator
There was a problem hiding this comment.
we should probably do this with some reduce
| ? 1 | ||
| : -1 | ||
| : a.name.localeCompare(b.name); | ||
| }); |
Collaborator
There was a problem hiding this comment.
the two arms are rather similar can we cut down on that? like have something like:
const compareByType = (a, b) =>
a.isDirectory !== b.isDirectory ? (a.isDirectory ? 1 : -1) : 0;
| matches: [], | ||
| matchedText: file.name, | ||
| })); // Show first 15 files when no query | ||
| const currentWorkingDir = window.appConfig.get('GOOSE_WORKING_DIR') as string; |
Collaborator
There was a problem hiding this comment.
you are using this twice, once defaulting to OS specifc. extract that and if you can be sure you have a value, get rid off 999
Contributor
|
Thank you for your contribution, @Abhijay007 ! |
Signed-off-by: Abhijay007 <[email protected]>
Contributor
|
I see this is approved, but wanted to check that your earlier comments are resolved @DOsinga ! Wanted to make sure before squash & merge :) |
zanesq
added a commit
that referenced
this pull request
Oct 13, 2025
…sion-streaming * 'main' of github.com:block/goose: (37 commits) Clear deeplinks after use (#5128) Revert "Fix gpt-5 input context limit (#4619)" (#5135) fix: missing cmake and protobuf for windows build, deduplicate sh/pws… (#5028) Fix bedrock tool input schema (#5064) Add self-test recipe for goose validation (#5111) fix: modifies openai request logic for reasoning models (#4221) (#4294) Fix race condition threat when set_param and set_secret of c… (#5109) Clean room implementation of the chat process (#5079) Bump rmcp (#5096) set version in an env variable for testing (#5100) fix : enhance fuzzy file search in goose desktop (#5071) Make async (#5126) docs: unlist tutorials for extensions with archived or moved servers (#5116) Add API Documentation Generator prompt (#5001) Add flag for enabling eleven labs voice dictation (#5095) force re-render fields to pick up custom params usage in instructions (#5112) Remove isUserInputDisabled (#5115) Improve Rust analysis output for `analyze` tool (#5072) Remove duplicate prepare_reply_context call (#5063) install react dev tools in development (#4979) ... # Conflicts: # ui/desktop/src/components/BaseChat2.tsx # ui/desktop/src/hooks/useChatStream.ts
katzdave
added a commit
that referenced
this pull request
Oct 15, 2025
* 'main' of github.com:block/goose: (49 commits) fixing video embed (#5171) chore: clean up random unused files (#5166) fix: adjust download_cli.sh to tolerate no OS variable (#5169) mcp tutorial page for firecrawl (#5152) Remove orphaned tool calls before compaction (#5059) feat: add copy as markdown button to documentation pages (#5158) chore: include vendored node executable (#5160) remove extra whitespace from message (#5159) Clear deeplinks after use (#5128) Revert "Fix gpt-5 input context limit (#4619)" (#5135) fix: missing cmake and protobuf for windows build, deduplicate sh/pws… (#5028) Fix bedrock tool input schema (#5064) Add self-test recipe for goose validation (#5111) fix: modifies openai request logic for reasoning models (#4221) (#4294) Fix race condition threat when set_param and set_secret of c… (#5109) Clean room implementation of the chat process (#5079) Bump rmcp (#5096) set version in an env variable for testing (#5100) fix : enhance fuzzy file search in goose desktop (#5071) Make async (#5126) ...
michaelneale
added a commit
that referenced
this pull request
Oct 16, 2025
* main: (35 commits) fix: include apple silicon build of the desktop app in build artifacts (#5174) fixing video embed (#5171) chore: clean up random unused files (#5166) fix: adjust download_cli.sh to tolerate no OS variable (#5169) mcp tutorial page for firecrawl (#5152) Remove orphaned tool calls before compaction (#5059) feat: add copy as markdown button to documentation pages (#5158) chore: include vendored node executable (#5160) remove extra whitespace from message (#5159) Clear deeplinks after use (#5128) Revert "Fix gpt-5 input context limit (#4619)" (#5135) fix: missing cmake and protobuf for windows build, deduplicate sh/pws… (#5028) Fix bedrock tool input schema (#5064) Add self-test recipe for goose validation (#5111) fix: modifies openai request logic for reasoning models (#4221) (#4294) Fix race condition threat when set_param and set_secret of c… (#5109) Clean room implementation of the chat process (#5079) Bump rmcp (#5096) set version in an env variable for testing (#5100) fix : enhance fuzzy file search in goose desktop (#5071) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5054
Pull Request Description
This PR aims to fix the "@" fuzzy/reference search functionality in Goose Desktop to show files relative to the current working directory instead of the entire system, and adds proper scrolling to display all available files without artificial limits.
Type of Change
Changes made:
File Search Scope: Changed "@" fuzzy search to start from the current working directory
GOOSE_WORKING_DIRinstead of user's home directory, and enhanced scoring algorithm to prioritize files closer to current working directory.Scrolling Support and UI Improvements: Removed artificial 8-file limit and added full scrolling functionality with max-height: 280px and smooth scroll behavior also added file count indicator and improved keyboard navigation with proper scroll-into-view behavior
Testing
Tested it in the Goose desktop by using the change
Screenshots/Demos (for UX changes)