install react dev tools in development

[jamadeo]

This works for me but it's a little flaky. It seems to fail showing the dev tools if there's another instance of goose also with the devtools running.

It also works once I open the chrome dev tools and then refresh the app.

[zanesq]

Thanks for doing this! I tested locally but didn't see any react devtools show up in inspector. Closed all other goose windows. Maybe I'm missing it where should it show up in devtools?

[jamadeo]

Ugh yeah it was flaky for me too. @zanesq did you try refreshing with the chrome dev tools open? I had to do that too

[jamadeo]

And do you see any logs from node? There were some mysterious errors from a service worker layer about not being able to delete an extension database when it wasn't working

[zanesq]

Just tried again and refresh didn't show the react dev tools profile or components tabs. I do have it installed in chrome and can see the tabs on other websites with react etc.

I do see some errore from node that could be related but not sure if those are on main or not.

[30030:1005/093428.209302:ERROR:extensions/browser/extensions_browser_client.cc:72] Extension Error:
  OTR:     false
  Level:   1
  Source:  manifest.json
  Message: Service worker registration failed. Status code: 2
  ID:      iedlfkhnniicohgmoebfngiecdmggbge
  Type:    ManifestError
[30030:1005/093429.047249:ERROR:components/services/storage/service_worker/service_worker_storage.cc:1732] Failed to delete the database: Database IO error
[30030:1005/093429.211030:ERROR:components/services/storage/service_worker/service_worker_storage.cc:1732] Failed to delete the database: Database IO error
09:38:40.038 › from renderer: [UNHANDLED REJECTION] SecurityError: Failed to construct 'SharedWorker': Access to the script at 'blob:http://localhost:5173/ee6cfff7-c7c5-4b56-a54a-312ada4a01b7' is denied by the document's Content Security Policy.
[30030:1006/084200.408321:ERROR:CONSOLE:2] "Electron sandboxed_renderer.bundle.js script failed to run", source: node:electron/js2c/sandbox_bundle (2)
[30030:1006/084200.408347:ERROR:CONSOLE:2] "TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))", source: node:electron/js2c/sandbox_bundle (2)
[30030:1006/084200.513678:ERROR:CONSOLE:1] "Request Autofill.enable failed. {"code":-32601,"message":"'Autofill.enable' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)
[30030:1006/084200.513711:ERROR:CONSOLE:1] "Request Autofill.setAddresses failed. {"code":-32601,"message":"'Autofill.setAddresses' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)

[jamadeo]

@zanesq thanks for that -- the "Failed to delete the database: Database IO error" is what I saw when it wouldn't work. Then I quit all other goose processes and did not see the error. I'm not sure what is going on there -- maybe something to do with the electron session persistence?

I do however see this even when it does work:

[84510:1006/121858.460288:ERROR:CONSOLE:2] "Electron sandboxed_renderer.bundle.js script failed to run", source: node:electron/js2c/sandbox_bundle (2)
[84510:1006/121858.460364:ERROR:CONSOLE:2] "TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))", source: node:electron/js2c/sandbox_bundle (2)
[84510:1006/121858.643086:ERROR:CONSOLE:1] "Request Autofill.enable failed. {"code":-32601,"message":"'Autofill.enable' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)
[84510:1006/121858.643139:ERROR:CONSOLE:1] "Request Autofill.setAddresses failed. {"code":-32601,"message":"'Autofill.setAddresses' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)

and this looks related:

electron/electron#41614

but it doesn't seem to break anything.

[jamadeo]

Also when you say

Closed all other goose windows

did you quit Goose entirely? I think if the window is closed but the app is still running, it does seem to still conflict

[zanesq]

Okay tried again exited all goose and I did see it after refreshing 👍 does seem flaky. Guess it's better than no react dev tools so approving.