Skip to content

chore: include vendored node executable #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexhancock merged 1 commit into from
Oct 14, 2025
Merged

chore: include vendored node executable #5160

alexhancock merged 1 commit into from
Oct 14, 2025

Conversation

@alexhancock
Copy link
Collaborator

@alexhancock alexhancock commented Oct 14, 2025 •
edited
Loading

  • Makes it so node is also bundled/vendored like npx
  • Same setup content as the npx previously had, but deduped between that script and the new node
  • Tested npx and node based extensions

@alexhancock alexhancock requested a review from jamadeo October 14, 2025 13:50
jamadeo
jamadeo approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@jamadeo jamadeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not need to be added here too?

goose/ui/desktop/src/components/settings/extensions/utils.ts

Line 193 in 5581ca3

export async function replaceWithShims(cmd: string) {

ui/desktop/src/bin/node-setup-common.sh

# Change to the ~/.config/goose/mcp-hermit directory
log "Changing to directory ~/.config/goose/mcp-hermit."
cd ~/.config/goose/mcp-hermit
Copy link
Collaborator

@jamadeo jamadeo Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I think a lot of this is also in the uvx script (the hermit part), could eventually do a bit more deduplicating

@alexhancock
Copy link
Collaborator Author

alexhancock commented Oct 14, 2025 •
edited
Loading

Does it not need to be added here too?

goose/ui/desktop/src/components/settings/extensions/utils.ts

Line 193 in 5581ca3

export async function replaceWithShims(cmd: string) {

Investigated and found that this adds the whole shims dir to the path:

goose/ui/desktop/src/goosed.ts

Lines 162 to 163 in 73e9e1a

// Set PATH to include the binary directory
PATH: `${path.dirname(resolvedGoosedPath)}${path.delimiter}${process.env.PATH || ''}`,

We need to do a larger cleanup where we remove the concept of replaceWithShims, and just have the shells which run extensions include the hermit directory in the PATH, but this will be a followup

@alexhancock alexhancock merged commit 0f8e073 into main Oct 14, 2025
11 checks passed
@alexhancock alexhancock deleted the alexhancock/vendored-node branch October 14, 2025 16:06
alexhancock added a commit that referenced this pull request Oct 14, 2025
@alexhancock
chore: include vendored node executable (#5160)
2e8cc70
katzdave added a commit that referenced this pull request Oct 15, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into error-proxy-2
79ba3f8 
* 'main' of github.com:block/goose: (49 commits)
  fixing video embed (#5171)
  chore: clean up random unused files (#5166)
  fix: adjust download_cli.sh to tolerate no OS variable (#5169)
  mcp tutorial page for firecrawl (#5152)
  Remove orphaned tool calls before compaction (#5059)
  feat: add copy as markdown button to documentation pages (#5158)
  chore: include vendored node executable (#5160)
  remove extra whitespace from message (#5159)
  Clear deeplinks after use (#5128)
  Revert "Fix gpt-5 input context limit (#4619)" (#5135)
  fix: missing cmake and protobuf for windows build, deduplicate sh/pws… (#5028)
  Fix bedrock tool input schema (#5064)
  Add self-test recipe for goose validation (#5111)
  fix: modifies openai request logic for reasoning models (#4221) (#4294)
  Fix race condition threat when set_param and set_secret of c… (#5109)
  Clean room implementation of the chat process (#5079)
  Bump rmcp (#5096)
  set version in an env variable for testing (#5100)
  fix : enhance fuzzy file search in goose desktop (#5071)
  Make async (#5126)
  ...
lifeizhou-ap added a commit that referenced this pull request Oct 15, 2025
@lifeizhou-ap
Merge branch 'main' into lifei/execute-recipe-server-side
9b429b7 
* main:
  fix: include apple silicon build of the desktop app in build artifacts (#5174)
  fixing video embed (#5171)
  chore: clean up random unused files (#5166)
  fix: adjust download_cli.sh to tolerate no OS variable (#5169)
  mcp tutorial page for firecrawl (#5152)
  Remove orphaned tool calls before compaction (#5059)
  feat: add copy as markdown button to documentation pages (#5158)
  chore: include vendored node executable (#5160)
  remove extra whitespace from message (#5159)
  Clear deeplinks after use (#5128)
  Revert "Fix gpt-5 input context limit (#4619)" (#5135)
  fix: missing cmake and protobuf for windows build, deduplicate sh/pws… (#5028)
tlongwell-block added a commit that referenced this pull request Oct 15, 2025
@tlongwell-block
Merge remote-tracking branch 'origin/main' into no_subagents_in_non_a…
ba52e3c 
…utonomous

* origin/main:
  feat: add Daily Standup Report Generator recipe (#5123)  (#5131)
  Sort providers in alphabetical vs random (#5090)
  Declarative providers (#5084)
  adding youtube link to firecrawl mcp tutorial, merge after 9am Eastern Oct 15 (#5173)
  Ollama integration: modified default model + added models  (#5153)
  Fix codex subagent configuration in documentation (#5180)
  fix: include apple silicon build of the desktop app in build artifacts (#5174)
  fixing video embed (#5171)
  chore: clean up random unused files (#5166)
  fix: adjust download_cli.sh to tolerate no OS variable (#5169)
  mcp tutorial page for firecrawl (#5152)
  Remove orphaned tool calls before compaction (#5059)
  feat: add copy as markdown button to documentation pages (#5158)
  chore: include vendored node executable (#5160)
  remove extra whitespace from message (#5159)
wpfleger96 added a commit to wpfleger96/goose that referenced this pull request Oct 15, 2025
@wpfleger96
Merge branch 'main' into wpfleger/standardize-session-attributes
d0b0c85 
* main: (55 commits)
  [docs] Add Blog Post: "Designing AI for Users, Not Just LLMs" (block#5190)
  docs: update cognee, jetbrains, mbot extensions config (block#5172)
  Minimally disable subagents when not in autonomous model (block#5149)
  Fix provider sort (block#5188)
  blog: Getting Started with Goose on Windows (block#5156)
  feat: add CI/CD Pipeline recipe (block#5183)
  feat: add Daily Standup Report Generator recipe (block#5123)  (block#5131)
  Sort providers in alphabetical vs random (block#5090)
  Declarative providers (block#5084)
  adding youtube link to firecrawl mcp tutorial, merge after 9am Eastern Oct 15 (block#5173)
  Ollama integration: modified default model + added models  (block#5153)
  Fix codex subagent configuration in documentation (block#5180)
  fix: include apple silicon build of the desktop app in build artifacts (block#5174)
  fixing video embed (block#5171)
  chore: clean up random unused files (block#5166)
  fix: adjust download_cli.sh to tolerate no OS variable (block#5169)
  mcp tutorial page for firecrawl (block#5152)
  Remove orphaned tool calls before compaction (block#5059)
  feat: add copy as markdown button to documentation pages (block#5158)
  chore: include vendored node executable (block#5160)
  ...
michaelneale added a commit that referenced this pull request Oct 16, 2025
@michaelneale
Merge branch 'main' into micn/goose-mobile-access
65f38bc 
* main: (35 commits)
  fix: include apple silicon build of the desktop app in build artifacts (#5174)
  fixing video embed (#5171)
  chore: clean up random unused files (#5166)
  fix: adjust download_cli.sh to tolerate no OS variable (#5169)
  mcp tutorial page for firecrawl (#5152)
  Remove orphaned tool calls before compaction (#5059)
  feat: add copy as markdown button to documentation pages (#5158)
  chore: include vendored node executable (#5160)
  remove extra whitespace from message (#5159)
  Clear deeplinks after use (#5128)
  Revert "Fix gpt-5 input context limit (#4619)" (#5135)
  fix: missing cmake and protobuf for windows build, deduplicate sh/pws… (#5028)
  Fix bedrock tool input schema (#5064)
  Add self-test recipe for goose validation (#5111)
  fix: modifies openai request logic for reasoning models (#4221) (#4294)
  Fix race condition threat when set_param and set_secret of c… (#5109)
  Clean room implementation of the chat process (#5079)
  Bump rmcp (#5096)
  set version in an env variable for testing (#5100)
  fix : enhance fuzzy file search in goose desktop (#5071)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamadeo jamadeo jamadeo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexhancock @jamadeo