Skip to content

Conversation

@Kvadratni
Copy link
Contributor

Wanna kill time while goose is thinking?
I got you covered fam:

Screen.Recording.2024-12-16.at.1.30.01.PM.mov

@Kvadratni Kvadratni requested a review from Copilot December 16, 2024 23:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

ui/desktop/src/components/FlappyGoose.tsx:20

  • [nitpick] The variable name 'framesLoaded' is ambiguous. It should be renamed to 'loadedFramesCount' for better clarity.
const framesLoaded = useRef(0);

ui/desktop/src/components/FlappyGoose.tsx:42

  • [nitpick] The constant 'GOOSE_SIZE' could be more descriptive, such as 'GOOSE_DIMENSION'.
const GOOSE_SIZE = 35;

ui/desktop/src/ChatWindow.tsx:18

  • [nitpick] The import statement should be alphabetically ordered with the other imports.
import FlappyGoose from './components/FlappyGoose';

@Kvadratni Kvadratni force-pushed the mnovich/flappy-goose branch 2 times, most recently from e20db8c to b5fd7f8 Compare December 16, 2024 23:48
@Kvadratni Kvadratni force-pushed the mnovich/flappy-goose branch from b5fd7f8 to 25e93ed Compare December 16, 2024 23:51
Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@Kvadratni Kvadratni merged commit 1327fc4 into v1.0 Dec 17, 2024
3 checks passed
michaelneale added a commit that referenced this pull request Dec 18, 2024
* v1.0:
  feat: add google provider (#489)
  feat: flappy goose easter egg (#479)
  Restore command history when resuming session (#483)
  Newline in cli (#485)
  remove cliclack prompt (#484)
  feat:model-specific-configuration (#466)
salman1993 added a commit that referenced this pull request Dec 18, 2024
* origin/v1.0:
  stop bubbles filling screen (#495)
  chore: V1.0 release automation (#493)
  requires foreign architectures
  more xcompile deps
  x compilation tools
  chore: Cargo build tokenizers (#491)
  feat: build and release binaries to GH releases (#477)
  fix: width of bubbles and logging errors (#487)
  feat: add google provider (#489)
  feat: flappy goose easter egg (#479)
jsibbison-square added a commit that referenced this pull request Dec 19, 2024
* v1.0:
  stop bubbles filling screen (#495)
  chore: V1.0 release automation (#493)
  requires foreign architectures
  more xcompile deps
  x compilation tools
  chore: Cargo build tokenizers (#491)
  feat: build and release binaries to GH releases (#477)
  fix: width of bubbles and logging errors (#487)
  feat: add google provider (#489)
  feat: flappy goose easter egg (#479)
@yingjiehe-xyz yingjiehe-xyz deleted the mnovich/flappy-goose branch February 5, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants