-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: build and release binaries to GH releases #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1f03dd to
1b3e939
Compare
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| architecture: [x86_64, aarch64] | ||
| include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the additional configs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a mechanism for adding extra config for a matching matrix variable, documented here. In this case it's defining a Rust target suffix based on the OS we're building on.
salman1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt! left a comment to better understand the include config
|
@salman1993 @baxen how are binaries published at the moment? this would make a LOT of noise in releases if it was each push vs cutting a release? (but we need to have binaries published somewhere publicly) |
|
(but could be the best approach if people don't mind many releases) |
|
@michaelneale this only triggers on a tag matching the regex, and currently there are no binaries published AFAICT |
Note that I can't really test this, but I successfully use something similar in an existing project.
1b3e939 to
df1bef2
Compare
|
ok yes, I like this. hard to test so I guess we just... try it? |
|
I haven't had much making this work - is there some source material I can look at for how people do it in rust? |
* origin/v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
* v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
Note that I can't really test this, but I successfully use something similar in an existing project.