Skip to content

Conversation

@alecthomas
Copy link
Contributor

Note that I can't really test this, but I successfully use something similar in an existing project.

@alecthomas alecthomas force-pushed the aat/v1.0-release-binaries branch from b1f03dd to 1b3e939 Compare December 16, 2024 11:34
matrix:
os: [ubuntu-latest, macos-latest]
architecture: [x86_64, aarch64]
include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the additional configs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a mechanism for adding extra config for a matching matrix variable, documented here. In this case it's defining a Rust target suffix based on the OS we're building on.

Copy link
Contributor

@salman1993 salman1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt! left a comment to better understand the include config

@michaelneale
Copy link
Collaborator

@salman1993 @baxen how are binaries published at the moment? this would make a LOT of noise in releases if it was each push vs cutting a release? (but we need to have binaries published somewhere publicly)

@michaelneale
Copy link
Collaborator

(but could be the best approach if people don't mind many releases)

@alecthomas
Copy link
Contributor Author

alecthomas commented Dec 17, 2024

@michaelneale this only triggers on a tag matching the regex, and currently there are no binaries published AFAICT

Note that I can't really test this, but I successfully use something
similar in an existing project.
@alecthomas alecthomas force-pushed the aat/v1.0-release-binaries branch from 1b3e939 to df1bef2 Compare December 17, 2024 00:54
@michaelneale
Copy link
Collaborator

ok yes, I like this. hard to test so I guess we just... try it?

@michaelneale michaelneale merged commit be17594 into block:v1.0 Dec 18, 2024
3 checks passed
@michaelneale
Copy link
Collaborator

I haven't had much making this work - is there some source material I can look at for how people do it in rust?

lifeizhou-ap added a commit that referenced this pull request Dec 18, 2024
* v1.0:
  requires foreign architectures
  more xcompile deps
  x compilation tools
  chore: Cargo build tokenizers (#491)
  feat: build and release binaries to GH releases (#477)
  fix: width of bubbles and logging errors (#487)
salman1993 added a commit that referenced this pull request Dec 18, 2024
* origin/v1.0:
  stop bubbles filling screen (#495)
  chore: V1.0 release automation (#493)
  requires foreign architectures
  more xcompile deps
  x compilation tools
  chore: Cargo build tokenizers (#491)
  feat: build and release binaries to GH releases (#477)
  fix: width of bubbles and logging errors (#487)
  feat: add google provider (#489)
  feat: flappy goose easter egg (#479)
jsibbison-square added a commit that referenced this pull request Dec 19, 2024
* v1.0:
  stop bubbles filling screen (#495)
  chore: V1.0 release automation (#493)
  requires foreign architectures
  more xcompile deps
  x compilation tools
  chore: Cargo build tokenizers (#491)
  feat: build and release binaries to GH releases (#477)
  fix: width of bubbles and logging errors (#487)
  feat: add google provider (#489)
  feat: flappy goose easter egg (#479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants