Newline in cli #485
Merged
Newline in cli #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baxen
approved these changes
Dec 17, 2024
Collaborator
baxen
left a comment
baxen
left a comment
There was a problem hiding this comment.
LGTM, easier to hit than ESC+Enter was
lifeizhou-ap
added a commit
that referenced
this pull request
Dec 17, 2024
michaelneale
added a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried all sorts of modifiers with ENTER and couldn't get any to work. We could implement it so if line ends with
\and enter is pressed it adds a newline but its a bit fragile given its only for the last line.Therefore I ended up with Ctrl+j which is 'linefeed' generally speaking. So it adds a newline wherever you are you can navigate anywhere with the arrow keys, you can also delete the new lines as needed so its a pretty good experience. The problem is knowing that 'Ctrl+j' is the shortcut to use. I added it to the help section but its the best option I've come across at the moment.