fix: docker build include valid string prior to sha #4613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlongwell-block
approved these changes
Sep 11, 2025
michaelneale
added a commit
that referenced
this pull request
Sep 15, 2025
* main: Soften str_replace instructions for weaker LLMs (#4639) docs: changed logo (#4633) Add `analyze` tool to Developer extension (#4530) Add recipe title in import form (#4625) Desktop json recipes upload (#4629) Catch errors in node main (#4627) chore(deps-dev): bump vite from 7.1.3 to 7.1.5 in /ui/desktop (#4583) docs: add Rube extension documentation and server configuration (#4556) Always show recipe activities at the top of chat when recipe accepted and active (#4616) Add parameter replacement to activities in ui (#4617) UI recipes filter invalid, duplicate and unused params (#4615) Fix gpt-5 input context limit (#4619) [docs] MCP-UI Blog Post (#4578) release/1.8.0 (#4577) fix: docker build include valid string prior to sha (#4613) Run the conversation fixer over messages for recipe create (#4605) docs: github copilot config workarounds (#4607) Add recipe schema validation to UI (#4602)
Merged
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed failing docker builds when the trigger is a tag
https://github.com/block/goose/actions/runs/17649096320/job/50154994435?pr=4577
Issue
The problematic line of the action config was:
type=sha,prefix={{branch}}-When this action runs on a tag (like
v1.8.0), the{{branch}}variable is empty, resulting in a tag that starts with just a hyphen:ghcr.io/block/goose:-881a71a. This is an invalid Docker tag format.Solution
Updated the workflow to use a fixed prefix:
type=sha,prefix=sha-This change ensures that SHA-based tags will always have a valid format like
ghcr.io/block/goose:sha-881a71aregardless of whether the workflow is triggered by a branch push or a tag