Skip to content

Conversation

@zanesq
Copy link
Collaborator

@zanesq zanesq commented Sep 10, 2025

Pull Request Description

Now that we have import recipe from file we should validate it as well.

Added recipe schema validation with tests:

  • Dynamic validation based on the currently generated openapi schema
  • Validates using existing Zod library that we use for form validation
  • JSON Schema validation is basic to avoid another library and eval issues with CSP settings

Bonus: added response JSON Schema field and generated schema reference help text in the create recipe UI

Note: this is a minor improvement before we unify the create forms across chat and recipe library.
Screenshot 2025-09-10 at 12 48 43 PM
Screenshot 2025-09-10 at 12 53 31 PM
Screenshot 2025-09-10 at 12 55 36 PM
Screenshot 2025-09-10 at 12 53 40 PM

…-validation

* 'main' of github.com:block/goose:
  Remove unused loadRecipe function (#4599)
Copy link
Collaborator

@amed-xyz amed-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -0,0 +1,565 @@
import { describe, it, expect } from 'vitest';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch

@zanesq zanesq merged commit ffc9705 into main Sep 10, 2025
11 checks passed
@zanesq zanesq deleted the zane/recipe-schema-validation branch September 10, 2025 23:26
thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025
michaelneale added a commit that referenced this pull request Sep 15, 2025
* main:
  Soften str_replace instructions for weaker LLMs (#4639)
  docs: changed logo (#4633)
  Add `analyze` tool to Developer extension (#4530)
  Add recipe title in import form (#4625)
  Desktop json recipes upload (#4629)
  Catch errors in node main (#4627)
  chore(deps-dev): bump vite from 7.1.3 to 7.1.5 in /ui/desktop (#4583)
  docs: add Rube extension documentation and server configuration (#4556)
  Always show recipe activities at the top of chat when recipe accepted and active (#4616)
  Add parameter replacement to activities in ui (#4617)
  UI recipes filter invalid, duplicate and unused params (#4615)
  Fix gpt-5 input context limit (#4619)
  [docs] MCP-UI Blog Post (#4578)
  release/1.8.0 (#4577)
  fix: docker build include valid string prior to sha (#4613)
  Run the conversation fixer over messages for recipe create (#4605)
  docs: github copilot config workarounds (#4607)
  Add recipe schema validation to UI (#4602)
@alexhancock alexhancock mentioned this pull request Sep 23, 2025
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants