Fix/settings page #4520
Merged
Fix/settings page #4520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove 'Show/Hide settings' text and position chevron on the right - Add smooth 300ms animate in/out transitions for dropdown content - Implement chevron rotation animation (0° to 180°) with 200ms duration - Use max-height and opacity transitions for smooth expand/collapse - Add transform transitions to setting items for polished feel - Maintain accessibility with proper button semantics
- Remove ml-6 left margin indentation from dropdown content - Change px-4 to px-2 to match ModeSelectionItem padding consistency - Maintain visual hierarchy while aligning with other setting components - Ensure Max Turns setting aligns properly with mode selection items
- Change text-textStandard to text-text-default for title consistency - Change text-textSubtle to text-text-muted for subtext consistency - Update chevron color from text-textSubtle to text-text-muted - Ensure all text styling matches ModeSelectionItem patterns
- Update text-textStandard to text-text-default for all titles - Update text-textSubtle to text-text-muted for all descriptions - Fix border and background color classes to use consistent naming - Ensure Voice Dictation styling matches Mode section patterns - Maintain visual hierarchy while improving consistency
- Create VoiceDictationToggle as main parent component with toggle logic - Extract ProviderSelector component for provider selection and dropdown - Create ElevenLabsKeyInput component for API key management - Add ProviderInfo component for provider-specific information - Simplify DictationSection to just render VoiceDictationToggle - Maintain all existing functionality while improving component organization - Use consistent styling patterns matching Mode section structure
- Implement same animation pattern as Conversation Limits dropdown - Add 300ms expand/collapse transitions with max-height and opacity - Use overflow-hidden with ease-in-out timing for natural movement - Maintain consistent spacing and layout during animations - Create cohesive animation experience across Chat settings section
- Remove CardHeader with 'Voice Dictation' title and description - Voice Dictation toggle now serves as its own title/header - Maintain Card wrapper for consistent spacing and background - Keep CardContent with px-2 for layout consistency - Eliminate duplicate labeling since toggle provides clear context
…e section - Replace native HTML radio buttons with custom styled radio pattern - Create schedulingEngineOptions data structure matching mode options format - Use same layout pattern as ModeSelectionItem (py-2 px-2 with hover states) - Fix text styling consistency (text-textStandard → text-text-default) - Update background colors (bg-bgSubtle → bg-background-subtle) - Add hover states and transitions matching other sections - Maintain all existing functionality and Electron integration - Improve visual consistency across Chat settings sections
- Remove ModeSection.tsx.backup - Remove SchedulerSection.tsx.backup - Remove DictationSection.tsx.backup - Clean up temporary files created during refactoring
- Remove obvious UI description comments (e.g., '/* Dropdown Header */') - Keep only comments that explain complex logic or non-obvious behavior - Retain important comments like cleanup logic explanation in ElevenLabsKeyInput - Remove redundant comments that simply describe what the JSX is doing - Improve code readability by reducing comment noise
- Remove text-xs from title to match Mode and Scheduling sections - Add text-sm to container div to match overall section sizing - Keep text-xs for descriptions (consistent with all sections) - Ensure Response Styles items are same size as other settings - Maintain all existing functionality and styling
…ections - Add text-sm to container div to match other sections - Remove text-xs from title to use default size (text-sm) - Keep text-xs for descriptions (consistent with all sections) - Ensure 'Disabled' and 'Enabled' options are same size as other settings - Maintain all existing functionality and backend integration
zanesq
approved these changes
Sep 4, 2025
ui/desktop/src/components/settings/chat/ChatSettingsSection.tsx
Outdated
Show resolved
Hide resolved
Removed comment
zanesq
approved these changes
Sep 5, 2025
michaelneale
added a commit
that referenced
this pull request
Sep 8, 2025
* main: docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492) feat(acp): Read files (#4531) Add YouTube Short to Auto Visualiser Tutorial (#4536) Fix/settings page (#4520) update to RMCP 0.6.2 (#4523)
katzdave
added a commit
that referenced
this pull request
Sep 8, 2025
* 'main' of github.com:block/goose: docs: add ampersand to link (#4560) Add video link to README for user guidance (#4553) docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492) feat(acp): Read files (#4531) Add YouTube Short to Auto Visualiser Tutorial (#4536) Fix/settings page (#4520) update to RMCP 0.6.2 (#4523) docs: nested goosehints (#4528) feat: Agent Client Protocol implementation of goose (#4511) feat: make tests for rmcp based developer server consistent with former implementation (#4519) worlds simplest logging to see where things are blocked (#3888) docs: update quickstart and install topics (#4378) feat: Add configurable Bedrock retry parameters (#4316) remove localstorage getconfig fallbacks (#4432) chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516)
tiensi
added a commit
to tiensi/goose
that referenced
this pull request
Sep 8, 2025
* main: (43 commits) feat: add auto-compact threshold configuration UI (block#4178) Add container detection to developer extension (block#4559) docs: add ampersand to link (block#4560) Add video link to README for user guidance (block#4553) docs: social channels (block#4552) feat: simplify navigation, make reload work (block#4498) docs: new recipe warning (block#4545) Add AGENTS.md for AI coding assistant support (block#4539) docs: non-interactive compact now (block#4543) fixed css classes and added some accessibility fixes (block#4492) feat(acp): Read files (block#4531) Add YouTube Short to Auto Visualiser Tutorial (block#4536) Fix/settings page (block#4520) update to RMCP 0.6.2 (block#4523) docs: nested goosehints (block#4528) feat: Agent Client Protocol implementation of goose (block#4511) feat: make tests for rmcp based developer server consistent with former implementation (block#4519) worlds simplest logging to see where things are blocked (block#3888) docs: update quickstart and install topics (block#4378) feat: Add configurable Bedrock retry parameters (block#4316) ...
This was referenced Sep 9, 2025
Merged
thebristolsound
pushed a commit
to thebristolsound/goose
that referenced
this pull request
Sep 11, 2025
Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Styling changes to Settings to unify text styling and component usage
Put conversation limits inside a dropdown
Voice dictation is just a toggle with reveal
Scheduling engine using right side radios
Moved various settings components within subfolders