fixed css classes and added some accessibility fixes #4492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e guide and directory structure for DESKTOP UI Signed-off-by: Carine Bruyndoncx <[email protected]>
zanesq
approved these changes
Sep 3, 2025
DESKTOP_UI_directory_structure.md
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Directory structure of ui/desktop/src | |||
Collaborator
There was a problem hiding this comment.
Appreciate the intent but these doc files tend to get out of date so we avoid them. Also there are a few things that are incorrect in the style guide. Can you remove the md files?
Contributor
Author
There was a problem hiding this comment.
Done, removed the markdown files
Collaborator
There was a problem hiding this comment.
Thanks, I agree we need to have a styleguide and truly appreciate it. Happy to take a look if you want to create a new PR with just the styleguide.md and keep it concise and relevant. The styleguide in this PR was way too broad / AI generated also was giving incorrect advice on using components like html button when we already have a Button component.
Contributor
Author
There was a problem hiding this comment.
Thanks, I agree we need to have a styleguide and truly appreciate it. Happy to take a look if you want to create a new PR with just the styleguide.md and keep it concise and relevant. The styleguide in this PR was way too broad / AI generated also was giving incorrect advice on using components like html button when we already have a
Buttoncomponent.
I can certainly add a PR with a draft, but i think it will need input from other people to make it good.
I have used goose with openai gpt-5-mini for the code changes. So I wanted to use it to guide the LLM, but i think your concern is more for the humans. Anyhow, I will add a draft PR and see where we land ...
Signed-off-by: Carine Bruyndoncx <[email protected]>
Signed-off-by: Carine Bruyndoncx <[email protected]>
cbruyndoncx
force-pushed
the
clean/customprovider-css
branch
from
295b4f8 to
96d7ec0
Compare
cbruyndoncx
changed the title
michaelneale
added a commit
that referenced
this pull request
Sep 8, 2025
* main: docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492) feat(acp): Read files (#4531) Add YouTube Short to Auto Visualiser Tutorial (#4536) Fix/settings page (#4520) update to RMCP 0.6.2 (#4523)
katzdave
added a commit
that referenced
this pull request
Sep 8, 2025
…data * 'main' of github.com:block/goose: docs: add ampersand to link (#4560) Add video link to README for user guidance (#4553) docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492)
katzdave
added a commit
that referenced
this pull request
Sep 8, 2025
* 'main' of github.com:block/goose: docs: add ampersand to link (#4560) Add video link to README for user guidance (#4553) docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492) feat(acp): Read files (#4531) Add YouTube Short to Auto Visualiser Tutorial (#4536) Fix/settings page (#4520) update to RMCP 0.6.2 (#4523) docs: nested goosehints (#4528) feat: Agent Client Protocol implementation of goose (#4511) feat: make tests for rmcp based developer server consistent with former implementation (#4519) worlds simplest logging to see where things are blocked (#3888) docs: update quickstart and install topics (#4378) feat: Add configurable Bedrock retry parameters (#4316) remove localstorage getconfig fallbacks (#4432) chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516)
tiensi
added a commit
to tiensi/goose
that referenced
this pull request
Sep 8, 2025
* main: (43 commits) feat: add auto-compact threshold configuration UI (block#4178) Add container detection to developer extension (block#4559) docs: add ampersand to link (block#4560) Add video link to README for user guidance (block#4553) docs: social channels (block#4552) feat: simplify navigation, make reload work (block#4498) docs: new recipe warning (block#4545) Add AGENTS.md for AI coding assistant support (block#4539) docs: non-interactive compact now (block#4543) fixed css classes and added some accessibility fixes (block#4492) feat(acp): Read files (block#4531) Add YouTube Short to Auto Visualiser Tutorial (block#4536) Fix/settings page (block#4520) update to RMCP 0.6.2 (block#4523) docs: nested goosehints (block#4528) feat: Agent Client Protocol implementation of goose (block#4511) feat: make tests for rmcp based developer server consistent with former implementation (block#4519) worlds simplest logging to see where things are blocked (block#3888) docs: update quickstart and install topics (block#4378) feat: Add configurable Bedrock retry parameters (block#4316) ...
This was referenced Sep 9, 2025
Merged
thebristolsound
pushed a commit
to thebristolsound/goose
that referenced
this pull request
Sep 11, 2025
Signed-off-by: Carine Bruyndoncx <[email protected]> Signed-off-by: Matt Donovan <[email protected]>
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Carine Bruyndoncx <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
fixed css classes and added some accessibility fixes,
incl draft style guide and directory structure for DESKTOP UI
UPDATE
REMOVED markdown fileas as requested