feat: make tests for rmcp based developer server consistent with former implementation #4519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelahning
approved these changes
Sep 4, 2025
| // Note: Full shell execution testing requires integration testing framework | ||
| // This test validates the ignore pattern logic that prevents access to restricted files. | ||
| // Clean up | ||
| let cancellation_token = running_service.cancellation_token(); |
Collaborator
There was a problem hiding this comment.
nit: should we extract this into a helper? It's duped a couple times.
| let cmd_parts: Vec<&str> = command.split_whitespace().collect(); | ||
| assert_eq!(cmd_parts[0], "cat"); | ||
| assert_eq!(cmd_parts[1], "secret.txt"); | ||
| fn test_bash_respects_ignore_patterns() { |
Collaborator
There was a problem hiding this comment.
nit: there are some tests that are named test_bash.. and some are test_shell...
…er implementation Co-authored-by: Angela Ning <[email protected]>
alexhancock
force-pushed
the
alexhancock/developer-test-rescue
branch
from
57fa0a8 to
a37357e
Compare
michaelneale
added a commit
that referenced
this pull request
Sep 5, 2025
* main: feat: make tests for rmcp based developer server consistent with former implementation (#4519) worlds simplest logging to see where things are blocked (#3888) docs: update quickstart and install topics (#4378) feat: Add configurable Bedrock retry parameters (#4316) remove localstorage getconfig fallbacks (#4432) chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516) Fix databricks streaming errors (#4506) docs: malware check for uvx and npx extensions (#4508)
katzdave
added a commit
that referenced
this pull request
Sep 8, 2025
* 'main' of github.com:block/goose: docs: add ampersand to link (#4560) Add video link to README for user guidance (#4553) docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492) feat(acp): Read files (#4531) Add YouTube Short to Auto Visualiser Tutorial (#4536) Fix/settings page (#4520) update to RMCP 0.6.2 (#4523) docs: nested goosehints (#4528) feat: Agent Client Protocol implementation of goose (#4511) feat: make tests for rmcp based developer server consistent with former implementation (#4519) worlds simplest logging to see where things are blocked (#3888) docs: update quickstart and install topics (#4378) feat: Add configurable Bedrock retry parameters (#4316) remove localstorage getconfig fallbacks (#4432) chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516)
tiensi
added a commit
to tiensi/goose
that referenced
this pull request
Sep 8, 2025
* main: (43 commits) feat: add auto-compact threshold configuration UI (block#4178) Add container detection to developer extension (block#4559) docs: add ampersand to link (block#4560) Add video link to README for user guidance (block#4553) docs: social channels (block#4552) feat: simplify navigation, make reload work (block#4498) docs: new recipe warning (block#4545) Add AGENTS.md for AI coding assistant support (block#4539) docs: non-interactive compact now (block#4543) fixed css classes and added some accessibility fixes (block#4492) feat(acp): Read files (block#4531) Add YouTube Short to Auto Visualiser Tutorial (block#4536) Fix/settings page (block#4520) update to RMCP 0.6.2 (block#4523) docs: nested goosehints (block#4528) feat: Agent Client Protocol implementation of goose (block#4511) feat: make tests for rmcp based developer server consistent with former implementation (block#4519) worlds simplest logging to see where things are blocked (block#3888) docs: update quickstart and install topics (block#4378) feat: Add configurable Bedrock retry parameters (block#4316) ...
This was referenced Sep 9, 2025
Merged
thebristolsound
pushed a commit
to thebristolsound/goose
that referenced
this pull request
Sep 11, 2025
…er implementation (block#4519) Co-authored-by: Angela Ning <[email protected]> Signed-off-by: Matt Donovan <[email protected]>
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…er implementation (block#4519) Co-authored-by: Angela Ning <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back tests from the former implementation of the
developerMCP