additional metrics + Ui implementation #3871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kvadratni
force-pushed
the
mnovich/OTLP-new-metrics
branch
from
1fb1686 to
5860eb6
Compare
Kvadratni
force-pushed
the
mnovich/OTLP-new-metrics
branch
3 times, most recently
from
9fca3b6 to
1dec3fb
Compare
| // Force flush of metrics by waiting a bit | ||
| // The meter provider doesn't have a direct shutdown method in the current SDK, | ||
| // but we can give it time to export any pending metrics | ||
| std::thread::sleep(std::time::Duration::from_millis(500)); |
Contributor
There was a problem hiding this comment.
this is another fixed sleep in addition to the one in the cli, can we just all the sleeps into here, make it conditional on otlp being exported (and ideally dynamic to keep as short as possible)?
Contributor
Author
There was a problem hiding this comment.
literally current limitation of sdk. no way to wait for it as I found. I may be overlooking something obvious tho
| if elapsed < rate_limit_duration { | ||
| let sleep_duration = rate_limit_duration - elapsed; | ||
| sleep(sleep_duration).await; | ||
| } |
Contributor
There was a problem hiding this comment.
Can we rely on the endpoint returning 429's (or non-200s) rather than arbitrary limiting here?
Contributor
Author
There was a problem hiding this comment.
its not a rate limit on the endpoint. the sdk itself didn't want to pipe at the necessary speed and just folded.
jsibbison-square
approved these changes
Aug 6, 2025
Contributor
jsibbison-square
left a comment
jsibbison-square
left a comment
There was a problem hiding this comment.
Happy to keep this moving through while we experiement with it. I'm a bit concerned about the arbitrary sleeps on cli exit but otherwise happy to push through.
Kvadratni
force-pushed
the
mnovich/OTLP-new-metrics
branch
from
1dec3fb to
2f784cf
Compare
katzdave
added a commit
that referenced
this pull request
Aug 6, 2025
* 'main' of github.com:block/goose: Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879) fix: optimise reading large file content (#3767) fix: replace glob/grep tool with shell (#3834) docs: Add Youtube Link to dev.to tutorial (#3869)
katzdave
added a commit
that referenced
this pull request
Aug 6, 2025
* 'main' of github.com:block/goose: Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879) fix: optimise reading large file content (#3767) fix: replace glob/grep tool with shell (#3834) docs: Add Youtube Link to dev.to tutorial (#3869)
michaelneale
added a commit
that referenced
this pull request
Aug 7, 2025
* main: Upgrade to MCP-UI ~5.6.2 and handle internalized auto iframe resizing (#3889) docs: recipe updates (#3844) added notes about reducing context window by referencing external files (#3895) Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further improves on goose metrics by adding mew types and expanding the coverage to the APP