Fix voice dictation provider selection bug #3862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJSwigut
force-pushed
the
swiggy/dictation-settings-issue-clean
branch
from
d31f258 to
6c31749
Compare
DOsinga
approved these changes
Aug 5, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
thanks for doing this! marked some LLM things to remove, otherwise good to go
ui/desktop/src/components/settings/dictation/DictationSection.tsx
Outdated
Show resolved
Hide resolved
ui/desktop/src/components/settings/dictation/DictationSection.tsx
Outdated
Show resolved
Hide resolved
ui/desktop/src/components/settings/dictation/DictationSection.tsx
Outdated
Show resolved
Hide resolved
ui/desktop/src/components/settings/dictation/DictationSection.tsx
Outdated
Show resolved
Hide resolved
katzdave
added a commit
that referenced
this pull request
Aug 6, 2025
* 'main' of github.com:block/goose: Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879) fix: optimise reading large file content (#3767) fix: replace glob/grep tool with shell (#3834) docs: Add Youtube Link to dev.to tutorial (#3869)
katzdave
added a commit
that referenced
this pull request
Aug 6, 2025
* 'main' of github.com:block/goose: Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879) fix: optimise reading large file content (#3767) fix: replace glob/grep tool with shell (#3834) docs: Add Youtube Link to dev.to tutorial (#3869)
michaelneale
added a commit
that referenced
this pull request
Aug 7, 2025
* main: Upgrade to MCP-UI ~5.6.2 and handle internalized auto iframe resizing (#3889) docs: recipe updates (#3844) added notes about reducing context window by referencing external files (#3895) Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix voice dictation provider selection bug
What
disabledattribute from OpenAI Whisper option in the voice dictation provider dropdownWhy
This fixes a critical UX bug where users would get permanently stuck after exploring ElevenLabs. The issue occurred because:
The root cause was the
disabled={!hasOpenAIKey}attribute that prevented any interaction with the OpenAI option once it was deemed "not configured".Key File Changes
ui/desktop/src/components/settings/dictation/DictationSection.tsx:disabledattribute from OpenAI Whisper buttonhandleDropdownTogglefunction to refresh provider statusImpact
Fixes #3226 and #3280
Screen.Recording.2025-08-05.at.11.59.05.AM.mov