feat: Add session description editing functionality #3819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the ability to edit session descriptions (names) in the History tab with a modal-based interface.
- Add PUT `/sessions/{session_id}/metadata` endpoint for updating session descriptions
- Implement 200-character validation limit with proper error handling
- Add `updateSessionMetadata` API function with error handling
- Implement modal-based editing UI with pencil icon on hover
- Add keyboard shortcuts (Enter to save, Escape to cancel)
- Include optimistic UI updates and toast notifications for user feedback
- Hover over any session card to reveal edit button in top-right corner
- Modal dialog with auto-focus and character limit validation
- Real-time UI updates with proper error recovery
- Maintains session context and working directory information
zanesq
reviewed
Aug 4, 2025
Collaborator
zanesq
left a comment
zanesq
left a comment
There was a problem hiding this comment.
Nice feature thanks! Couple of nits:
- Can you align the pencil vertically with the heading and left more to match the padding in the card? Currently its a bit too much in the corner, also if possible add a bit more padding or size to the button so its easier to hover/click?
- The success toast shows for a few seconds before the UI updates, wondering if we could get that timed a little better so the ui updates at the same time or before the toast shows?
…tTimeout felt simpler than introducing more state management to control it in the parent component
Contributor
Author
|
@zanesq I've addressed your feedback in the latest 2 commits. The toast is delayed by a simple setTimeout - this felt simpler than using more state management, let me know if you'd prefer a more sophisticated approach. |
Collaborator
|
@anthony changes look good thanks! I changed the icon size back to the smaller one. Looks like there is a rust format issue preventing build. |
Contributor
Author
|
@zanesq I believe I've fixed the rust formatting issue |
Contributor
Author
|
My previous test run failed with what appeared unrelated failures. I've merged main to hopefully address the issue. |
zanesq
approved these changes
Aug 6, 2025
katzdave
added a commit
that referenced
this pull request
Aug 6, 2025
* 'main' of github.com:block/goose: Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879) fix: optimise reading large file content (#3767) fix: replace glob/grep tool with shell (#3834) docs: Add Youtube Link to dev.to tutorial (#3869)
katzdave
added a commit
that referenced
this pull request
Aug 6, 2025
* 'main' of github.com:block/goose: Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879) fix: optimise reading large file content (#3767) fix: replace glob/grep tool with shell (#3834) docs: Add Youtube Link to dev.to tutorial (#3869)
michaelneale
added a commit
that referenced
this pull request
Aug 7, 2025
* main: Upgrade to MCP-UI ~5.6.2 and handle internalized auto iframe resizing (#3889) docs: recipe updates (#3844) added notes about reducing context window by referencing external files (#3895) Make the window title reflect what we are doing (#3883) additional metrics + Ui implementation (#3871) feat: Add session description editing functionality (#3819) Update filename in contributing docs (#3866) Fix voice dictation provider selection bug (#3862) doc: Update supported container runtimes (#3874) feat: add OAuth provider abstraction for CLI configuration (#3157) Don't ignore lockfiles on linux/windows builds (#3859) Use RMCP for StreamableHTTP OAuth support (#3845) Try to keep key order for Databricks (#3876) Fix OpenAI Provider with GitHub Models (#3875) Cmd click open finder (#3807) fix: recipe parameter form max height and not scrolling (#3879)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #3270 after the recent UI updates.
Implements the ability to edit session descriptions (names) in the History tab with a modal-based interface.
Changes
Backend (Rust)
/sessions/{session_id}/metadataendpoint for updating session descriptionsFrontend (TypeScript)
updateSessionMetadataAPI function with error handlingFeatures