chore: use a Conversation type #3735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
commented
Jul 30, 2025
DOsinga
approved these changes
Jul 31, 2025
crates/goose/src/conversation.rs
Outdated
| @@ -0,0 +1,109 @@ | |||
| use serde::{Deserialize, Serialize}; | |||
Collaborator
There was a problem hiding this comment.
we have a message folder - we could rename that to conversation and move this there and also the conversation fixer
Collaborator
|
you should probably get this in when you get a chance seeing how quickly this bit of the code moves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a Conversation type to use over Vec. This lets us keep message merging and validation within the type.
For now this is a thin wrapper around Vec and doesn't do the validation yet.