Skip to content

Conversation

@iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Aug 2, 2025

Fixes: #3779

Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
@DOsinga
Copy link
Collaborator

DOsinga commented Aug 2, 2025

thanks for jumping on this so quickly!

Copy link
Collaborator

@katzdave katzdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this concept of keeping around messages + tagging them as ancestors, but this doesn't help us when we close/re-open goose. I'd want that to all be consistent.

#3735 should help with being able to track more metadata on messages maybe you can follow up on that.

@iamrajiv
Copy link
Contributor Author

iamrajiv commented Aug 4, 2025

yeah @katzdave my fix is partial only works within a session so should i wait for #3735 to get merged?

@katzdave
Copy link
Collaborator

katzdave commented Aug 4, 2025

yeah @katzdave my fix is partial only works within a session so should i wait for #3735 to get merged?

I think so; would really like the full load on a fresh session to work the same way rather than have different code paths there.

@iamrajiv
Copy link
Contributor Author

iamrajiv commented Aug 4, 2025

sure thanks @katzdave will wait

@michaelneale
Copy link
Collaborator

@iamrajiv you ready to update this to main - other change has been merged.

@zanesq
Copy link
Collaborator

zanesq commented Aug 22, 2025

Still in progress?

@katzdave
Copy link
Collaborator

katzdave commented Sep 2, 2025

Closing this for now; I'm working on a change now to address this by keeping all messages inside the session metadata (including pre-compaction) and tagging them with metadata so they're filtered out of what gets sent to the agent.

@katzdave katzdave closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After summarization and reload previous messages are missing, resume crashes

5 participants