fixed recipe schedule jobs #3880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOsinga
approved these changes
Aug 6, 2025
| match mode { | ||
| Some("foreground") => "auto".to_string(), | ||
| Some("background") => "chat".to_string(), | ||
| Some("foreground") => "chat".to_string(), |
Collaborator
There was a problem hiding this comment.
I never understood this code, how would chat help in either foreground or background mode?
Collaborator
Author
There was a problem hiding this comment.
This is a good question. My understanding is:
-
This is only used in the
defaultscheduler mode (not the temporal scheduler mode) -
For
temporalmode, it opens a new window with theforegroundjob. -
I tested
defaultmode withforegroundjob, it seems working as the same as background job except different mode. Just wondering do we still needforegroundfordefaultschedule job? @Kvadratni
| onStop={onStopGoose} | ||
| commandHistory={commandHistory} | ||
| initialValue={_input || ''} | ||
| initialValue={recipeConfig?.isScheduledExecution ? '' : _input || ''} |
Collaborator
There was a problem hiding this comment.
let's drop the _ for input here while we are at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3882
What
chatmode forforegroundjob andautofor background job