chore: refactor session naming into provider #3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelahning
force-pushed
the
aning/session-nameing
branch
from
db71b7c to
9d2a4aa
Compare
alexhancock
approved these changes
Jul 28, 2025
DOsinga
approved these changes
Jul 28, 2025
| /// | ||
| /// # Errors | ||
| /// ProviderError if the session name generation fails | ||
| async fn generate_session_name(&self, messages: &[Message]) -> Result<String, ProviderError> { |
Collaborator
There was a problem hiding this comment.
below and possibly above: I have my quest to delete comments that don't help, can you make it so :) ?
| ) | ||
| // Use the provider's session naming capability | ||
| let sanitized_description = provider | ||
| .generate_session_name(messages) |
Collaborator
There was a problem hiding this comment.
much better! still not really where it should be called from, but we can clean that up some other time
angelahning
force-pushed
the
aning/session-nameing
branch
from
ea03c1b to
7611bbe
Compare
michaelneale
added a commit
that referenced
this pull request
Jul 29, 2025
* main: blog: streamlining detection development w/ recipes (#3689) fix: have option for cli providers to use their configured or default model (#3683) docs: new blog post and corrections to an old one on goosehints (#3657) Resolve sub recipe path relative to the parent recipe path (#3642) Speed up recipe loading from deeplinks and various fixes (#3662) fix cmd + , not opening settings (#3694) Add warning when JSON env parsing fails. (#3696) chore: refactor session naming into provider (#3678) feat (ui): File picker for scheduling recipes default to recipe dir (#3611) fix: address issue with streamable http interactions via mcp (#3693) Provider scenario tests (#3688) Fix conversations before they hit the LLM (#3660) cli: add detailed instruction for WSL users (#3496) feat: recipe runs will now prompt for missing extension secrets (#3668) fix: pricing integration tests -> trying more runs for cache and retries (#3546)
michaelneale
added a commit
that referenced
this pull request
Jul 29, 2025
* main: fix: Ensures final output tool is available when using vector tool search (#3701) chore: adding in some new models token limits (#3685) blog: streamlining detection development w/ recipes (#3689) fix: have option for cli providers to use their configured or default model (#3683) docs: new blog post and corrections to an old one on goosehints (#3657) Resolve sub recipe path relative to the parent recipe path (#3642) Speed up recipe loading from deeplinks and various fixes (#3662) fix cmd + , not opening settings (#3694) Add warning when JSON env parsing fails. (#3696) chore: refactor session naming into provider (#3678) feat (ui): File picker for scheduling recipes default to recipe dir (#3611) fix: address issue with streamable http interactions via mcp (#3693) Provider scenario tests (#3688)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves session naming logic from storage.rs into the Provider trait, allowing providers to implement custom session naming strategies while maintaining full backwards compatibility.