-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore: refactor session naming into provider #3678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1294,52 +1294,15 @@ pub async fn generate_description_with_schedule_id( | |
| )); | ||
| } | ||
|
|
||
| // Create a special message asking for a 3-word description | ||
| let mut description_prompt = "Based on the conversation so far, provide a concise description of this session in 4 words or less. This will be used for finding the session later in a UI with limited space - reply *ONLY* with the description".to_string(); | ||
|
|
||
| // get context from messages so far, limiting each message to 300 chars for security | ||
| let context: Vec<String> = messages | ||
| .iter() | ||
| .filter(|m| m.role == rmcp::model::Role::User) | ||
| .take(3) // Use up to first 3 user messages for context | ||
| .map(|m| { | ||
| let text = m.as_concat_text(); | ||
| safe_truncate(&text, 300) | ||
| }) | ||
| .collect(); | ||
|
|
||
| if !context.is_empty() { | ||
| description_prompt = format!( | ||
| "Here are the first few user messages:\n{}\n\n{}", | ||
| context.join("\n"), | ||
| description_prompt | ||
| ); | ||
| } | ||
|
|
||
| // Generate the description with error handling | ||
| let message = Message::user().with_text(&description_prompt); | ||
| let result = provider | ||
| .complete( | ||
| "Reply with only a description in four words or less", | ||
| &[message], | ||
| &[], | ||
| ) | ||
| // Use the provider's session naming capability | ||
| let sanitized_description = provider | ||
| .generate_session_name(messages) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. much better! still not really where it should be called from, but we can clean that up some other time |
||
| .await | ||
| .map_err(|e| { | ||
| tracing::error!("Failed to generate session description: {}", e); | ||
| anyhow::anyhow!("Failed to generate session description") | ||
| })?; | ||
|
|
||
| let description = result.0.as_concat_text(); | ||
|
|
||
| // Validate description length for security | ||
| let sanitized_description = if description.chars().count() > 100 { | ||
| tracing::warn!("Generated description too long, truncating"); | ||
| safe_truncate(&description, 100) | ||
| } else { | ||
| description | ||
| }; | ||
|
|
||
| // Create metadata with proper working_dir or read existing and update | ||
| let mut metadata = if secure_path.exists() { | ||
| read_metadata(&secure_path)? | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
below and possibly above: I have my quest to delete comments that don't help, can you make it so :) ?