Skip to content

Conversation

@alexhancock
Copy link
Collaborator

@alexhancock alexhancock commented Jul 28, 2025

  • Adding a fix for an issue with streamable http mcp servers discovered by @tadasant
  • Adding tests

@alexhancock alexhancock requested review from DOsinga and jamadeo July 28, 2025 17:10
@tadasant
Copy link

tadasant commented Jul 28, 2025

discovered by @Tadas

@tadasant ** :)

Thank you for digging into this!!

@alexhancock
Copy link
Collaborator Author

alexhancock commented Jul 28, 2025

discovered by @Tadas

@tadasant ** :)

Thank you for digging into this!!

replaced!

@tadasant
Copy link

Confirming this solves the minimal repro I had communicated to @alexhancock, and additionally is unblocking me on running long-running sub-recipes when I combine it with my draft PR in #3691 (which fixes task_timeout not being respected by the subagent invoked by the sub-recipe). Thank you!

Copy link
Collaborator

@katzdave katzdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Nice tests!

@alexhancock alexhancock merged commit 959f51f into main Jul 28, 2025
8 checks passed
@alexhancock alexhancock deleted the alexhancock/fix-streamable-http branch July 28, 2025 19:02
michaelneale added a commit that referenced this pull request Jul 29, 2025
* main:
  blog: streamlining detection development w/ recipes (#3689)
  fix: have option for cli providers to use their configured or default model  (#3683)
  docs: new blog post and corrections to an old one on goosehints (#3657)
  Resolve sub recipe path relative to the parent recipe path (#3642)
  Speed up recipe loading from deeplinks and various fixes (#3662)
  fix cmd + , not opening settings (#3694)
  Add warning when JSON env parsing fails. (#3696)
  chore: refactor session naming into provider (#3678)
  feat (ui): File picker for scheduling recipes default to recipe dir (#3611)
  fix: address issue with streamable http interactions via mcp (#3693)
  Provider scenario tests (#3688)
  Fix conversations before they hit the LLM (#3660)
  cli: add detailed instruction for WSL users (#3496)
  feat: recipe runs will now prompt for missing extension secrets (#3668)
  fix: pricing integration tests -> trying more runs for cache and retries (#3546)
michaelneale added a commit that referenced this pull request Jul 29, 2025
* main:
  fix: Ensures final output tool is available when using vector tool search (#3701)
  chore: adding in some new models token limits (#3685)
  blog: streamlining detection development w/ recipes (#3689)
  fix: have option for cli providers to use their configured or default model  (#3683)
  docs: new blog post and corrections to an old one on goosehints (#3657)
  Resolve sub recipe path relative to the parent recipe path (#3642)
  Speed up recipe loading from deeplinks and various fixes (#3662)
  fix cmd + , not opening settings (#3694)
  Add warning when JSON env parsing fails. (#3696)
  chore: refactor session naming into provider (#3678)
  feat (ui): File picker for scheduling recipes default to recipe dir (#3611)
  fix: address issue with streamable http interactions via mcp (#3693)
  Provider scenario tests (#3688)
atarantino pushed a commit to atarantino/goose that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants