-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Drop temporal-service binary #3340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm assuming this was accidentally committed. Remove it and add a .gitignore to prevent it from coming back. I noticed this repository when cloning is now over 1G. This is surprising for a repository of this age and scope. For reference the Linux kernel repository's `.git` is now 3.4G. There are a few causes to this (the large high resolution photos in `documentation/` are one) but in looking around, this binary executable is one that is almost certainly a mistake. If it's not a mistake it needs a good bit of justification I think. Signed-off-by: Colin Walters <[email protected]>
|
Let me use this PR to ask a related question: Is no one actually using AI (via goose even) to review PRs to this repo? Using the prompt:
to try to simulate this, and using I think stuff like this is part of its system prompt? Using goose+gemini-2.5-pro didn't flag it though. |
|
@cgwalters yeah we might not need a compiled version in. the build should build a new one every time. |
I don't think there's a "might" here, I cannot think of any good rationale to have a pregenerated binary committed to the git repo. As claude said, this is what release artifacts are for - but those who want to build from source shouldn't be concerned with those.
Not sure I'd say 27MB is measly to start, I mean the entire history of an active ~12 year old project I have is 57MB. But leaving that aside: it's ~27MB multipled by every commit that changed that code and then blindly committing new versions of the binary: i.e. ~roughly currently 297MB of the |
|
@cgwalters yeah sometimes I do actually use it - mainly for things I don't understand (but if I ask too general stuff, I find often the advice is too general) but use it a lot with build/optimisations, but not so much with PRs (but it is something we will have to do - but it is tricky to not get it in a self contratulatory/approving loop! or you can bias it too negatively and rejects too much!). yeah I think it is important to not have a binary - this repo is already uncomfortably big due to history of things, so agree, it is nice to housekeep like this. |
Signed-off-by: Colin Walters <[email protected]>
* 'main' of github.com:block/goose: [cli] Add --provider and --model CLI options to run command (#3295) Docs: Lead/worker model in Goose Desktop (#3342) revert: refactor: abstract keyring logic to better enable DI (#3358) Drop temporal-service binary (#3340) docs: add fuzzy search (#3357) Fix name of GPT-4.1 System Prompt (#3348) (#3351)
* main: (51 commits) docs: reflecting benefits of CLI providers (block#3399) feat: fetch openrouter supported models in `goose configure` (block#3347) Add the ability to configure rustyline to use a different edit mode (e.g. vi) (block#2769) docs: update CLI provider guide (block#3397) Streamable HTTP CLI flag (block#3394) docs: Show both remote options for extensions in CLI (block#3392) docs: fix YouTube Transcript MCP package manager (block#3390) docs: simplify alby mcp (block#3379) docs: add max turns (block#3372) feat(cli): add cost estimation per provider for Goose CLI (block#3330) feat: Allow Ollama for non-tool models for chat only (block#3308) [cli] Add --provider and --model CLI options to run command (block#3295) Docs: Lead/worker model in Goose Desktop (block#3342) revert: refactor: abstract keyring logic to better enable DI (block#3358) Drop temporal-service binary (block#3340) docs: add fuzzy search (block#3357) Fix name of GPT-4.1 System Prompt (block#3348) (block#3351) docs: add goose-mobile (block#3315) refactor: abstract keyring logic to better enable DI (block#3262) fix: correct tool use for anthropic (block#3311) ...
Signed-off-by: Colin Walters <[email protected]> Signed-off-by: Adam Tarantino <[email protected]>
Signed-off-by: Colin Walters <[email protected]> Signed-off-by: Soroosh <[email protected]>
Signed-off-by: Colin Walters <[email protected]> Signed-off-by: Kyle Santiago <[email protected]>
Signed-off-by: Colin Walters <[email protected]>
I'm assuming this was accidentally committed. Remove it and add a .gitignore to prevent it from coming back.
I noticed this repository when cloning is now over 1G. This is surprising for a repository of this age and scope. For reference the Linux kernel repository's
.gitis now 3.4G.There are a few causes to this (the large high resolution photos in
documentation/are one) but in looking around, this binary executable is one that is almost certainly a mistake. If it's not a mistake it needs a good bit of justification I think.