Add the ability to configure rustyline to use a different edit mode (e.g. vi) #2769
Conversation
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
(Not a maintainer here, just doing a few drive by PR reviews in the hope of paying down some debt to get mine reviewed 😉 )
…_edit_mode * 'vi_edit_mode' of github.com:ayax79/goose: Made edit_mode optional and inlined determine_edit_mode Add the ability to configure rustyline to use EDIT_MODE
|
nice - I think people that know about emacs conventions in UI input and want an alternative should have it, and doesn't change default @cgwalters appreciate your diligence - we will need more maintainers soon I think! be careful what you wish for haha I updated this to main, and tidied up some clippy/fmt errors |
|
sorry @cgwalters do you mind updating/resolving the conflicts? I had a look but worry I would break it |
michaelneale
added
clarification
I am interested in this conversation; I like four aspects of Goose:
And I'd like to try to convince my employer to invest a bit more formally based on this. I can't promise anything right now, but that's my hope.
Hi @michaelneale I'm not the PR author. I just did a drive by review here. |
|
oh apologies @cgwalters ! sorry @ayax79 would you be interested in continuing (some conflicts to resolve) |
|
@michaelneale fixed! |
* 'main' of github.com:block/goose: feat: fetch openrouter supported models in `goose configure` (#3347) Add the ability to configure rustyline to use a different edit mode (e.g. vi) (#2769) docs: update CLI provider guide (#3397) Streamable HTTP CLI flag (#3394) docs: Show both remote options for extensions in CLI (#3392)
* main: (51 commits) docs: reflecting benefits of CLI providers (block#3399) feat: fetch openrouter supported models in `goose configure` (block#3347) Add the ability to configure rustyline to use a different edit mode (e.g. vi) (block#2769) docs: update CLI provider guide (block#3397) Streamable HTTP CLI flag (block#3394) docs: Show both remote options for extensions in CLI (block#3392) docs: fix YouTube Transcript MCP package manager (block#3390) docs: simplify alby mcp (block#3379) docs: add max turns (block#3372) feat(cli): add cost estimation per provider for Goose CLI (block#3330) feat: Allow Ollama for non-tool models for chat only (block#3308) [cli] Add --provider and --model CLI options to run command (block#3295) Docs: Lead/worker model in Goose Desktop (block#3342) revert: refactor: abstract keyring logic to better enable DI (block#3358) Drop temporal-service binary (block#3340) docs: add fuzzy search (block#3357) Fix name of GPT-4.1 System Prompt (block#3348) (block#3351) docs: add goose-mobile (block#3315) refactor: abstract keyring logic to better enable DI (block#3262) fix: correct tool use for anthropic (block#3311) ...
…e.g. vi) (block#2769) Co-authored-by: Jack Wright <[email protected]> Co-authored-by: Michael Neale <[email protected]> Signed-off-by: Adam Tarantino <[email protected]>
…e.g. vi) (block#2769) Co-authored-by: Jack Wright <[email protected]> Co-authored-by: Michael Neale <[email protected]> Signed-off-by: Soroosh <[email protected]>
…e.g. vi) (block#2769) Co-authored-by: Jack Wright <[email protected]> Co-authored-by: Michael Neale <[email protected]> Signed-off-by: Kyle Santiago <[email protected]>
…e.g. vi) (block#2769) Co-authored-by: Jack Wright <[email protected]> Co-authored-by: Michael Neale <[email protected]>
3 participants
By default the cli only supports emacs key bindings. This pull request allows a configuration parameter EDIT_MODE to be set that will allow the rustyline edit mode to be explicitly set. The following config allows the edit mode to be set to vi: