Skip to content

Conversation

@haydenth
Copy link
Contributor

@haydenth haydenth commented Jul 8, 2025

  • Add --provider and --model CLI arguments to run command for LLM selection
  • Thread provider and model options through SessionBuilderConfig structure
  • Implement priority order: CLI args > settings > environment variables
  • Update bench command and session builder to support new options
  • Update all relevant struct initializations with new fields

Solves #2435

@alexhancock alexhancock self-requested a review July 11, 2025 14:40
Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please complete the DCO step - instructions here and then good to merge

Thank you for the contribution!

- Add --provider and --model CLI arguments to run command for LLM selection
- Thread provider and model options through SessionBuilderConfig structure
- Implement priority order: CLI args > settings > environment variables
- Update bench command and session builder to support new options
- Update all relevant struct initializations with new fields

Signed-off-by: Tom Hayden <[email protected]>
@alexhancock alexhancock merged commit 3cdb642 into block:main Jul 11, 2025
7 checks passed
zanesq added a commit that referenced this pull request Jul 11, 2025
* 'main' of github.com:block/goose:
  [cli] Add --provider and --model CLI options to run command (#3295)
  Docs: Lead/worker model in Goose Desktop (#3342)
  revert: refactor: abstract keyring logic to better enable DI (#3358)
  Drop temporal-service binary (#3340)
  docs: add fuzzy search (#3357)
  Fix name of GPT-4.1 System Prompt (#3348) (#3351)
michaelneale added a commit to jackjackbits/goose that referenced this pull request Jul 14, 2025
* main: (51 commits)
  docs: reflecting benefits of CLI providers (block#3399)
  feat: fetch openrouter supported models in `goose configure` (block#3347)
  Add the ability to configure rustyline to use a different edit mode (e.g. vi) (block#2769)
  docs: update CLI provider guide (block#3397)
  Streamable HTTP CLI flag (block#3394)
  docs: Show both remote options for extensions in CLI (block#3392)
  docs: fix YouTube Transcript MCP package manager (block#3390)
  docs: simplify alby mcp (block#3379)
  docs: add max turns (block#3372)
  feat(cli): add cost estimation per provider for Goose CLI (block#3330)
  feat: Allow Ollama for non-tool models for chat only (block#3308)
  [cli] Add --provider and --model CLI options to run command (block#3295)
  Docs: Lead/worker model in Goose Desktop (block#3342)
  revert: refactor: abstract keyring logic to better enable DI (block#3358)
  Drop temporal-service binary (block#3340)
  docs: add fuzzy search (block#3357)
  Fix name of GPT-4.1 System Prompt (block#3348) (block#3351)
  docs: add goose-mobile (block#3315)
  refactor: abstract keyring logic to better enable DI (block#3262)
  fix: correct tool use for anthropic (block#3311)
  ...
atarantino pushed a commit to atarantino/goose that referenced this pull request Jul 14, 2025
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
kwsantiago pushed a commit to kwsantiago/goose that referenced this pull request Jul 19, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants