feat: Add AZURE_OPENAI_API_KEY as a visible config parameter #3265
Conversation
AZURE_OPENAI_API_KEY was previously an optional parameter and since only required parameters are visible in the UI, it was not possible to configure it. Let's make it required with an empty string as the default value.
|
I think this may confuse users who do not realize it's optional. Perhaps you can add "optional" in the label? |
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
I can't manually validate it with azure but this seems to make sense
Good idea! I agree that it is a bit confusing, although I'm not sure what would be the best way to clarify it, so open to suggestions. I think we could rename |
michaelneale
added
p3
|
so if It has a value which says it is optional? (I am confused as to the aim now - ideally we wouldn't make an optional thing not optional?) |
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
need to clarify how it is actually still optional
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
I think this is better than it was so am ok with it, and is isolated.
) Signed-off-by: Adam Tarantino <[email protected]>
* main: fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) fix checkout for non mac builds (#3408) Docs: Voice dictation in Goose Desktop (#3376) docs: cli theme persistence (#3398) docs: goose mobile (#3403)
* 'main' of github.com:block/goose: fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) # Conflicts: # crates/goose/src/session/storage.rs # ui/desktop/src/components/ChatView.tsx # ui/desktop/src/components/settings/extensions/subcomponents/ExtensionList.tsx
) Signed-off-by: Soroosh <[email protected]>
) Signed-off-by: Kyle Santiago <[email protected]>
4 participants
AZURE_OPENAI_API_KEY was previously an optional parameter and since only required parameters are visible in the UI, it was not possible to configure it. Let's make it required with an empty string as the default value. See also #2582.
Example from the UI
