-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: recipe list (#2814)
#2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: toyamagu2021 <[email protected]>
1ab1d4a to
3b8b681
Compare
| let output = Command::new("gh") | ||
| .args(["api", &format!("repos/{}/contents", repo)]) | ||
| .output() | ||
| .map_err(|e| anyhow!("Failed to execute gh api command: {}", e))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we include a more descriptive message explaining that the command relies on gh being installed and configured for auth?
I also wonder if we could interact with the API instead, and just have the user progress through an oauth flow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we should just skip here and show the user the recipes that are accessible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in some cases goose will then offer to install it for you if the error is returned in an interactive way (eg if an MCP fails), wonder if can do similar here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the error message easier to understand.
Since ensure_gh_authenticated is executed beforehand, the login workflow will appear if you are not logged in, as shown below. You can authenticate within this workflow as follows:
➜ goose git:(feat/recipe-list) ./target/release/goose recipe list
You are not logged into any GitHub hosts. To log in, run: gh auth login
GitHub CLI is not authenticated. Launching `gh auth login`...
? Where do you use GitHub? GitHub.com
? How would you like to authenticate GitHub CLI? Login with a web browser
Signed-off-by: toyamagu-2021 <[email protected]>
Signed-off-by: toyamagu-2021 <[email protected]>
Signed-off-by: toyamagu-2021 <[email protected]>
Signed-off-by: toyamagu-2021 <[email protected]>
Signed-off-by: toyamagu-2021 <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* 'main' of github.com:block/goose: fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) # Conflicts: # crates/goose/src/session/storage.rs # ui/desktop/src/components/ChatView.tsx # ui/desktop/src/components/settings/extensions/subcomponents/ExtensionList.tsx
* main: (54 commits) UI update with sidebar and settings tabs (#3288) docs: add CLIStreamExtensionInstructions component (#3443) chore(release): release version 1.0.36 (#3436) [goose-llm] fix image content bug, add optional request_id field (#3439) fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) ...
* main: UI update with sidebar and settings tabs (#3288) docs: add CLIStreamExtensionInstructions component (#3443) chore(release): release version 1.0.36 (#3436) [goose-llm] fix image content bug, add optional request_id field (#3439) fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264)
Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: toyamagu-2021 <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: Soroosh <[email protected]>
Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: toyamagu-2021 <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: Kyle Santiago <[email protected]>
Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: toyamagu-2021 <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: toyamagu2021 <[email protected]> Signed-off-by: toyamagu-2021 <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: Adam Tarantino <[email protected]>
Signed-off-by: toyamagu2021 [email protected]
Closes #2814
Motivation
recipe listVerification
recipe list
recipe list --format json
recipe list --verbose