fix checkout for non mac builds #3408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
reviewed
Jul 14, 2025
| with: | ||
| ref: ${{ inputs.ref }} | ||
| # Only pass ref if it's explicitly set, otherwise let checkout action use its default behavior | ||
| ref: ${{ inputs.ref != '' && inputs.ref || '' }} |
Collaborator
There was a problem hiding this comment.
maybe I'm missing something, but this looks like if inputs.ref is an empty string we will pass an empty string? how is that different from the prior behavior?
Contributor
Author
There was a problem hiding this comment.
honestly just making it the same as the mac workflow as that one is the only one that actually does the right thing
jamadeo
approved these changes
Jul 14, 2025
zanesq
added a commit
that referenced
this pull request
Jul 14, 2025
* 'main' of github.com:block/goose: fix checkout for non mac builds (#3408)
zanesq
added a commit
that referenced
this pull request
Jul 14, 2025
…update * 'zane/ui-update' of github.com:block/goose: fix sidebar animations after removing framer motion removed staggering animation from session items to reduce animations on load fix checkout for non mac builds (#3408)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Jul 14, 2025
does not affect builds. Signed-off-by: Adam Tarantino <[email protected]>
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 15, 2025
* main: fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) fix checkout for non mac builds (#3408) Docs: Voice dictation in Goose Desktop (#3376) docs: cli theme persistence (#3398) docs: goose mobile (#3403)
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
does not affect builds. Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
does not affect builds. Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
does not affect builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.