feat(ui): Add confirmation dialog for unsaved changes in extension modal #2971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add confirmation dialog when closing extension modal with unsaved changes - Detect changes in command/endpoint fields and environment variables - Track pending input in environment variable fields before clicking Add - Apply confirmation logic to both backdrop clicks and Cancel button - Improve UX by preventing accidental loss of configuration data Changes: - ExtensionModal.tsx: Add change detection and confirmation dialog logic - EnvVarsSection.tsx: Add callback to track pending input in new env var fields Fixes issue where users could accidentally close modal and lose entered API keys or configuration data by clicking outside the modal.
alexrrouse
force-pushed
the
feature/extension-modal-unsaved-changes-confirmation
branch
2 times, most recently
from
853f1b4 to
56f8baa
Compare
zanesq
approved these changes
Jun 17, 2025
michaelneale
added a commit
that referenced
this pull request
Jun 18, 2025
* main: (26 commits) chore(release): release version 1.0.29 (#2978) [fix][small] Replaced goose prompt unicode quotations with ascii quotations (#2972) fix: goose recipe prompt is not shown again when switch the view from settings to chat (#2870) fix: remove computer controller presentation (#2956) Fix GitHub Copilot Provider Config (#2955) Blog: Why I Used Goose to Build a Chaotic Emotion Detection App (#2959) Docs: Recipe settings (#2970) feat(ui): Add confirmation dialog for unsaved changes in extension modal (#2971) feat: alphabetize extensions in goose CLI (#2966) switch roles on condition for windows (#2975) fix version param for canary (#2974) enabling windows builds with code signing (#2968) feat(cli): add system prompt parameter to run command (#2253) Fix window not showing for some users (#2967) Add documentation for running with Ramalama local model serving in OCI Containers (#1973) Reddit MCP Server Tutorial (#2949) [fix] goose not quitting app completely (#2950) Opopadich/issue 1625 (#2904) chore(deps): bump go.temporal.io/api from 1.24.0 to 1.44.1 in /temporal-service (#2837) feat: add newline at end of file writes (#2221) ...
laanak08
added a commit
that referenced
this pull request
Jun 18, 2025
* main: (28 commits) feat: optional fast edit models (#2580) feat: Add lead-worker model selection and real-time model display in GUI (#2964) chore(release): release version 1.0.29 (#2978) [fix][small] Replaced goose prompt unicode quotations with ascii quotations (#2972) fix: goose recipe prompt is not shown again when switch the view from settings to chat (#2870) fix: remove computer controller presentation (#2956) Fix GitHub Copilot Provider Config (#2955) Blog: Why I Used Goose to Build a Chaotic Emotion Detection App (#2959) Docs: Recipe settings (#2970) feat(ui): Add confirmation dialog for unsaved changes in extension modal (#2971) feat: alphabetize extensions in goose CLI (#2966) switch roles on condition for windows (#2975) fix version param for canary (#2974) enabling windows builds with code signing (#2968) feat(cli): add system prompt parameter to run command (#2253) Fix window not showing for some users (#2967) Add documentation for running with Ramalama local model serving in OCI Containers (#1973) Reddit MCP Server Tutorial (#2949) [fix] goose not quitting app completely (#2950) Opopadich/issue 1625 (#2904) ...
alexrrouse
deleted the
feature/extension-modal-unsaved-changes-confirmation
branch
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
…dal (block#2971) Co-authored-by: Alex Rouse <[email protected]> Signed-off-by: Soroosh <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
…dal (block#2971) Co-authored-by: Alex Rouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a confirmation dialog when users try to close the extension modal with unsaved changes, preventing accidental loss of configuration data.
Problem
I had experienced frustration when accidentally clicking outside the extension modal (backdrop) accidentally after entering API keys that I had copied and closed the window that they came from causing me to re-generate the keys.
We listen for changes in the environment variables and the command fields for requiring the prompt, since the name/description fields are a bit easier to reproduce.
Screen.Recording.2025-06-17.at.3.22.34.PM.mov